From: Michael Hope <michael.hope@linaro.org>
To: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Cc: crossgcc@sourceware.org
Subject: Re: [PATCH] scripts: Make the crosstool-NG version an optional part of pkgversion
Date: Tue, 18 Oct 2011 19:43:00 -0000 [thread overview]
Message-ID: <CANLjY-=P2CbUfsGw=ZU9ZijnX75sTw-QGjbbnXqwsRtWu_zCeg@mail.gmail.com> (raw)
In-Reply-To: <201110181820.27777.yann.morin.1998@anciens.enib.fr>
On Wed, Oct 19, 2011 at 5:20 AM, Yann E. MORIN
<yann.morin.1998@anciens.enib.fr> wrote:
> Michael, All,
>
> On Monday 17 October 2011 05:39:47 Michael Hope wrote:
>> # HG changeset patch
>> # User Michael Hope <michael.hope@linaro.org>
>> # Date 1317709748 -46800
>> # Node ID 931a96c7b84610c33a5535f574adf01df63d1a89
>> # Parent 5b157f46a3ab4830e4117811e9338e7d74d3a55d
>> scripts: Make the crosstool-NG version an optional part of pkgversion.
>
> If I may ask, what is the reason you (Linaro) would not want to identify
> crosstool-NG in the pkgversion string?
Just brevity. We set the Linaro release as the default package
version, so for source builds you get a string like:
gcc (Linaro GCC 4.6-2011.09) 4.6.2 20110908 (prerelease)
For binary builds I was planning on using a pkgversion like 'Linaro
GCC 4.6-2011.09+bin1' to show the particular build script release used
to make the binary. We need to identify the build scripts to fully
meet the terms of the GPL.
> Would it be better if the crosstool-NG ID string was placed _after_ the
> custom string?
Yeah, that would be fine.
>> We use the pkgversion for the Linaro release name. This patch lets you
>> turn off the automatic crosstool-NG@revno and just use the configured
>> package version.
>
> Note that, for release, the 'revno' is replaced by the version string,
> so it is much shorter; that is, something like:
> crosstool-NG 1.12.4
>
>> +config TOOLCHAIN_PKGVERSION_WITH_CROSSTOOL
>> + bool
>> + prompt "Include the crosstool-NG version in the ID string"
>> + default y
>> + help
>> + Include the crosstool-NG version in the package version string.
>
> If this was to make it in, I would add:
> depends on TOOLCHAIN_PKGVERSION != ""
>
> So there's at least one pkgversion string:
> - the crosstool-NG ID string
> - the crosstool-NG + the custom ID strings
> - the custom ID string
>
> OK for you?
I'd like to withdraw the patch for now and think about it some more.
Linaro work upstream, but no matter what we'll end up with a branch
for patches that aren't upstreamable. Therefore a name like 'Linaro
GCC yyyy.mm + crosstool-NG r12345' isn't true as it's not crosstool-NG
r12345, but r12345 of our branch.
-- Michael
--
For unsubscribe information see http://sourceware.org/lists.html#faq
next prev parent reply other threads:[~2011-10-18 19:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 3:40 Michael Hope
2011-10-18 16:20 ` Yann E. MORIN
2011-10-18 19:43 ` Michael Hope [this message]
2011-10-18 21:02 ` Yann E. MORIN
2011-10-18 22:46 ` Michael Hope
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANLjY-=P2CbUfsGw=ZU9ZijnX75sTw-QGjbbnXqwsRtWu_zCeg@mail.gmail.com' \
--to=michael.hope@linaro.org \
--cc=crossgcc@sourceware.org \
--cc=yann.morin.1998@anciens.enib.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).