From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13999 invoked by alias); 22 Nov 2011 20:13:41 -0000 Received: (qmail 13990 invoked by uid 22791); 22 Nov 2011 20:13:37 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-ww0-f41.google.com (HELO mail-ww0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Nov 2011 20:13:17 +0000 Received: by wwf25 with SMTP id 25so7653176wwf.0 for ; Tue, 22 Nov 2011 12:13:16 -0800 (PST) Received: by 10.227.198.212 with SMTP id ep20mr13106583wbb.9.1321992796099; Tue, 22 Nov 2011 12:13:16 -0800 (PST) MIME-Version: 1.0 Received: by 10.180.82.2 with HTTP; Tue, 22 Nov 2011 12:12:55 -0800 (PST) In-Reply-To: <201111221823.56129.yann.morin.1998@anciens.enib.fr> References: <4ECB8D46.1040002@linaro.org> <201111221823.56129.yann.morin.1998@anciens.enib.fr> From: Michael Hope Date: Tue, 22 Nov 2011 20:13:00 -0000 Message-ID: Subject: Re: [nls PATCH 2 of 3] binutils/binutils: Handle --disable-nls config To: "Yann E. MORIN" Cc: crossgcc@sourceware.org, Zhenqiang Chen Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00135.txt.bz2 On Wed, Nov 23, 2011 at 6:23 AM, Yann E. MORIN wrote: > Zhenqiang, All, > > On Tuesday 22 November 2011 12:53:42 Zhenqiang Chen wrote: >> # HG changeset patch >> # User Zhenqiang Chen >> # Date 1321523984 -28800 >> # Node ID 640bdfd7d1efc1b91ad54304fefe6db77179ec65 >> # Parent =A0986e1c75432aad60ae3239767198c653c08c01af >> binutils/binutils: Add --disable-nls config when >> option "Enable nls" is not selected. >> >> Reviewed-by: Michael Hope >> Signed-off-by: Zhenqiang Chen >> >> diff --git a/scripts/build/binutils/binutils.sh b/scripts/build/binutils= /binutils.sh >> --- a/scripts/build/binutils/binutils.sh >> +++ b/scripts/build/binutils/binutils.sh >> @@ -62,6 +62,8 @@ >> =A0 =A0 =A0 =A0 =A0 [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=3D(= "--with-bugurl=3D${CT_TOOLCHAIN_BUGURL}") >> =A0 =A0 =A0 fi >> >> + =A0 =A0[ "${CT_TOOLCHAIN_ENABLE_NLS}" !=3D "y" ] && extra_config+=3D("= --disable-nls") > > Shoudn't we also force --enable-nls otherwise? NLS is on by default and has to be explicitly turned off using --disable-nls. See binutils/config/nls.m4: AC_ARG_ENABLE(nls, [ --disable-nls do not use Native Language Support], USE_NLS=3D$enableval, USE_NLS=3Dyes) -- Michael -- For unsubscribe information see http://sourceware.org/lists.html#faq