From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12314 invoked by alias); 4 Feb 2014 21:33:07 -0000 Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org Received: (qmail 12265 invoked by uid 89); 4 Feb 2014 21:33:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wg0-f41.google.com Received: from mail-wg0-f41.google.com (HELO mail-wg0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 04 Feb 2014 21:33:05 +0000 Received: by mail-wg0-f41.google.com with SMTP id n12so4899059wgh.4 for ; Tue, 04 Feb 2014 13:33:01 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.180.102.42 with SMTP id fl10mr14455174wib.42.1391549581884; Tue, 04 Feb 2014 13:33:01 -0800 (PST) Received: by 10.227.206.2 with HTTP; Tue, 4 Feb 2014 13:33:01 -0800 (PST) In-Reply-To: References: Date: Tue, 04 Feb 2014 21:33:00 -0000 Message-ID: Subject: Re: [PATCH 3/3] {e}glibc: Fix various multilib build bugs From: Ray Donnelly To: Bryan Hundven Cc: "crossgcc@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00019.txt.bz2 I'm not having the best time of it today! Bryan, I forgot to CC the ML (so most of this you got already) but also, there's a dumb error in my patch: target = $(get_multilib_target "${extra_flags}") needs to be changed to: target=$(get_multilib_target "${extra_flags}") On Tue, Feb 4, 2014 at 8:14 PM, Bryan Hundven wrote: > Ray, Cody, list, > > On Tue, Feb 4, 2014 at 10:49 AM, Ray Donnelly wrote: >> Here is the new version using Cody's get_multilib_target () function. >> >> Cheers, >> >> Ray. > > I have some comments on this commit, but it's attached :( > I recommend using the patchbomb method: > http://crosstool-ng.org/hg/crosstool-ng/file/529a71ea091e/docs/C%20-%20Misc.%20tutorials.txt#l183 > Sorry about the attachments, I've only submitted a few minor patches so far and nothing that needed much discussion. Is patchbomb easy to setup with gmail? If you can point me at some instructions that'd be appreciated. IMHO ctng should move to Git and use Gerrit (or failing that maybe just github) for these code reviews, but I understand that this would be quite a significant time drain to implement. > Anyways, it seems to me that get_multilib_target should be stubbed in > scripts/build/arch/multilib.sh, and implemented in the respective > scripts/build/arch/.sh > Source multilib.sh after this line: > http://crosstool-ng.org/hg/crosstool-ng/file/529a71ea091e/scripts/crosstool-NG.sh.in#l140 > I agree we could move get_multilib_target somewhere more general purpose, but I'd put it into multilib.sh and leave it at that. Personally, I prefer having the full gory details available in (and easily testable from) a single function rather than splitting it up. > That way, any package - beyond (e)glibc - can obtain the multilib > target info if needed. > > Other points are easier to discuss inline. Cody, Ray; what are your thoughts? > > -Bryan -- For unsubscribe information see http://sourceware.org/lists.html#faq