public inbox for crossgcc@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] scripts/showSamples.sh: fix list-samples
@ 2012-07-03  3:22 Bryan Hundven
  2012-07-23 21:40 ` Yann E. MORIN
  0 siblings, 1 reply; 2+ messages in thread
From: Bryan Hundven @ 2012-07-03  3:22 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

# HG changeset patch
# User Bryan Hundven <bryanhundven@gmail.com>
# Date 1341284878 25200
# Node ID e489fc02a7ab0a7e04b922728bf898dee80d0ee4
# Parent  4c8fd10c18e94975239a69897f38d9eb046fad8c
scripts/showSamples.sh: fix list-samples

If $(pwd)/.config.sample doesn't exist, don't try to source it.
Also, don't forget to quote it, as the parent directories might have
spaces or other weird characters.

Signed-off-by: Bryan Hundven <bryanhundven@gmail.com>

diff -r 4c8fd10c18e9 -r e489fc02a7ab scripts/showSamples.sh
--- a/scripts/showSamples.sh	Mon Jun 18 13:36:29 2012 +0200
+++ b/scripts/showSamples.sh	Mon Jul 02 20:07:58 2012 -0700
@@ -37,7 +37,7 @@
             fi
             ;;
     esac
-    . $(pwd)/.config.sample
+    [ -r "$(pwd)/.config.sample" ] && . "$(pwd)/.config.sample"
     if [ -z "${wiki}" ]; then
         t_width=14
         printf "%-*s  [%s" ${width} "${sample}" "${sample_type}"

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] scripts/showSamples.sh: fix list-samples
  2012-07-03  3:22 [PATCH] scripts/showSamples.sh: fix list-samples Bryan Hundven
@ 2012-07-23 21:40 ` Yann E. MORIN
  0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2012-07-23 21:40 UTC (permalink / raw)
  To: crossgcc; +Cc: Bryan Hundven

Bryan, All,

On Tuesday 03 July 2012 05:09:43 Bryan Hundven wrote:
> # HG changeset patch
> # User Bryan Hundven <bryanhundven@gmail.com>
> # Date 1341284878 25200
> # Node ID e489fc02a7ab0a7e04b922728bf898dee80d0ee4
> # Parent  4c8fd10c18e94975239a69897f38d9eb046fad8c
> scripts/showSamples.sh: fix list-samples

I dropped this one, and implemented a much-more complex fix as #95173b196a88.

The basis of the change is that, since we're now using defconfig to save the
samples, we can no longer rely on the saved samples' .config file, and we need
to regenerate a complete .config before we can even try to parse the config.

Thank you for reporting the issue!

Regards,
Yann E. MORIN (sorry for the delay).

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-07-23 21:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-03  3:22 [PATCH] scripts/showSamples.sh: fix list-samples Bryan Hundven
2012-07-23 21:40 ` Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).