From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101896 invoked by alias); 19 Jan 2017 10:02:56 -0000 Mailing-List: contact cygwin-apps-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cygwin-apps-cvs-owner@sourceware.org Received: (qmail 101873 invoked by uid 9078); 19 Jan 2017 10:02:56 -0000 Date: Thu, 19 Jan 2017 10:02:00 -0000 Message-ID: <20170119100256.101847.qmail@sourceware.org> From: corinna@sourceware.org To: cygwin-apps-cvs@sourceware.org Subject: [csih - Cygwin service installation helper, a helper script and tools to create service installation scripts] branch master, updated. v0_9_9-2-g5e210bc X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 128ed704ed13cda2f3b2e336dba4aeb27a70bdd6 X-Git-Newrev: 5e210bc57bd36a9c7b935ccf16707742584cb566 X-SW-Source: 2017-q1/txt/msg00002.txt.bz2 https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/csih.git;h=5e210bc57bd36a9c7b935ccf16707742584cb566 commit 5e210bc57bd36a9c7b935ccf16707742584cb566 Author: Shaddy Baddah Date: Wed Jan 18 14:34:04 2017 +1100 ssh-host-config: patch fix debug option + broken for me on Vista (non-domain) Hi, First please find attached a simple patch that fixes a problem I encountered running ssh-host-config with the --debug option. Pretty simple. Without redirecting the output of csih_stacktrace() to stderr, then (3.5.4) Command Substitution of functions that call it will run into problems. And the one that I encountered was this one: cygwin-service-installation-helper.sh:1147:csih_mktemp () cygwin-service-installation-helper.sh:1148:{ cygwin-service-installation-helper.sh:1149: csih_stacktrace "${@}" cygwin-service-installation-helper.sh:1150: $_csih_trace cygwin-service-installation-helper.sh:1152: local __umask=$(umask) cygwin-service-installation-helper.sh:1153: local rval cygwin-service-installation-helper.sh:1154: local tmpdir cygwin-service-installation-helper.sh:1156: tmpdir=$(csih_writable_tmpdir) || return 1 cygwin-service-installation-helper.sh:1158: umask 0077 cygwin-service-installation-helper.sh:1159: /usr/bin/mktemp --tmpdir="${tmpdir}" "$@" tmpdir will be filled with stacktrace output from the csih_writable_tmpdir() call, and mktemp will fail. Diff: --- cygwin-service-installation-helper.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cygwin-service-installation-helper.sh b/cygwin-service-installation-helper.sh index 60d4bec..a0b6216 100755 --- a/cygwin-service-installation-helper.sh +++ b/cygwin-service-installation-helper.sh @@ -384,7 +384,7 @@ csih_stacktrace() fi n=$(($n-1)) done - echo -e "${_csih_STACKTRACE_STR} ${val} ${@}" + echo -e "${_csih_STACKTRACE_STR} ${val} ${@}" 1>&2 fi } # === End of csih_stacktrace() === # readonly -f csih_stacktrace