public inbox for cygwin-apps-cvs@sourceware.org
help / color / mirror / Atom feed
From: jturney@sourceware.org
To: cygwin-apps-cvs@sourceware.org
Subject: [calm - Cygwin server-side packaging maintenance script] branch master, updated. 20160705-63-g83faeef
Date: Tue, 11 Apr 2017 15:02:00 -0000	[thread overview]
Message-ID: <20170411150214.124733.qmail@sourceware.org> (raw)




https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/calm.git;h=83faeef19bb1c5a8fd2a9283cb7752bfe41aed52

commit 83faeef19bb1c5a8fd2a9283cb7752bfe41aed52
Author: Jon Turney <jturney@sourceware.org>
Date:   Thu May 12 16:45:33 2016 +0000

    Tweak email recipents
    
    Add stromeko to errors list
    Add jturney and yselkowitz to Bcc list

https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/calm.git;h=e3f4bcfc8699211e24a58063f6094287d7f09d78

commit e3f4bcfc8699211e24a58063f6094287d7f09d78
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date:   Fri Jun 24 14:23:51 2016 +0100

    Also check for skip: but install files
    
    Check the condition both ways, so the presence/absence of skip: matches
    absence/presence of an install tarfile


Diff:
---
 calm/package.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/calm/package.py b/calm/package.py
index 7d5a5d5..0513084 100755
--- a/calm/package.py
+++ b/calm/package.py
@@ -468,7 +468,7 @@ def validate_packages(args, packages):
                 packages[p].skip = True
                 logging.info("package '%s' appears to be source-only as it has no non-empty install tarfiles and no dependencies, marking as 'skip'" % (p))
 
-        elif has_install:
+        elif has_install and any(['skip' in version_hints[vr] for vr in vr_list]):
             logging.error("package '%s' has 'skip:' hint but also has install tarfiles" % (p))
             error = True
 


                 reply	other threads:[~2017-04-11 15:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170411150214.124733.qmail@sourceware.org \
    --to=jturney@sourceware.org \
    --cc=cygwin-apps-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).