public inbox for cygwin-apps-cvs@sourceware.org
help / color / mirror / Atom feed
From: jturney@sourceware.org
To: cygwin-apps-cvs@sourceware.org
Subject: [setup - the official Cygwin setup program used to install Cygwin and keep it up to date] branch master, updated. release_2.879-15-g9b4b982
Date: Tue, 23 May 2017 16:17:00 -0000	[thread overview]
Message-ID: <20170523161704.60995.qmail@sourceware.org> (raw)




https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/setup.git;h=9b4b982d5548c60547f6a2593157146e1784fa1d

commit 9b4b982d5548c60547f6a2593157146e1784fa1d
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date:   Tue May 23 14:40:24 2017 +0100

    Restore a missing NULL-ness check
    
    Accidentally dropped in 249e9360.  This could go away if
    packagesource::Canonical() was changed to return std::string and other uses
    checked empty() rather than against NULL.


Diff:
---
 download.cc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/download.cc b/download.cc
index 59af2d6..80615f3 100644
--- a/download.cc
+++ b/download.cc
@@ -78,7 +78,7 @@ check_for_cached (packagesource & pkgsource, bool mirror_mode)
 
   /* Note that the cache dir is represented by a mirror site of file://local_dir */
   std::string prefix = "file://" + local_dir + "/";
-  std::string fullname = prefix + pkgsource.Canonical();
+  std::string fullname = prefix + (pkgsource.Canonical() ? pkgsource.Canonical() : "");
 
   if (mirror_mode)
     {


                 reply	other threads:[~2017-05-23 16:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170523161704.60995.qmail@sourceware.org \
    --to=jturney@sourceware.org \
    --cc=cygwin-apps-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).