public inbox for cygwin-apps-cvs@sourceware.org help / color / mirror / Atom feed
From: jturney@sourceware.org To: cygwin-apps-cvs@sourceware.org Subject: [calm - Cygwin server-side packaging maintenance script] branch master, updated. 20160705-96-g3e00aa0 Date: Fri, 06 Oct 2017 11:35:00 -0000 [thread overview] Message-ID: <20171006113503.40061.qmail@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/calm.git;h=3e00aa05586a70468332fe280678ed6a2f6ea9c4 commit 3e00aa05586a70468332fe280678ed6a2f6ea9c4 Author: Jon Turney <jon.turney@dronecode.org.uk> Date: Fri Oct 6 12:29:04 2017 +0100 Fix validate_package_maintainers to handle absent category hints. When an old source-only package (which has a .hint containing just skip:) is changed to an installable package, a category doesn't exist for all versions. Traceback (most recent call last): File "./calm/calm.py", line 508, in do_daemon state.packages = process_uploads(args, state) File "./calm/calm.py", line 192, in process_uploads if not package.validate_packages(args, merged_packages[arch]): File "./calm/package.py", line 680, in validate_packages validate_package_maintainers(args, packages) File "./calm/package.py", line 703, in validate_package_maintainers if any(['_obsolete' in packages[p].version_hints[vr]['category'] for vr in packages[p].version_hints]): File "./calm/package.py", line 703, in <listcomp> if any(['_obsolete' in packages[p].version_hints[vr]['category'] for vr in packages[p].version_hints]): KeyError: 'category' Diff: --- calm/package.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/calm/package.py b/calm/package.py index 23954dd..cf9d242 100755 --- a/calm/package.py +++ b/calm/package.py @@ -700,7 +700,7 @@ def validate_package_maintainers(args, packages): if packages[p].skip: continue # ignore obsolete packages - if any(['_obsolete' in packages[p].version_hints[vr]['category'] for vr in packages[p].version_hints]): + if any(['_obsolete' in packages[p].version_hints[vr].get('category', '') for vr in packages[p].version_hints]): continue if not is_in_package_list(packages[p].path, all_packages): logging.error("package '%s' is not in the package list" % (p))
reply other threads:[~2017-10-06 11:35 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171006113503.40061.qmail@sourceware.org \ --to=jturney@sourceware.org \ --cc=cygwin-apps-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).