public inbox for cygwin-apps-cvs@sourceware.org help / color / mirror / Atom feed
From: jturney@sourceware.org To: cygwin-apps-cvs@sourceware.org Subject: [setup - the official Cygwin setup program] branch master, updated. release_2.891-2-ga176683 Date: Thu, 22 Mar 2018 22:03:00 -0000 [thread overview] Message-ID: <20180322220338.19722.qmail@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/setup.git;h=a1766832dda3e2594c5f0b18602daf753ebe7c8f commit a1766832dda3e2594c5f0b18602daf753ebe7c8f Author: Ken Brown <kbrown@cornell.edu> Date: Wed Mar 21 14:03:00 2018 -0400 Give a fatal error on a checksum failure during install This only affects local installs, where the hash of an archive is not checked until we reach do_install_thread(). At this point it seems too late to recover safely. Diff: --- install.cc | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/install.cc b/install.cc index 37dea6f..b5adcc6 100644 --- a/install.cc +++ b/install.cc @@ -850,7 +850,15 @@ do_install_thread (HINSTANCE h, HWND owner) } catch (Exception *e) { - yesno (owner, IDS_SKIP_PACKAGE, e->what()); + // We used to give the user a yes/no option to skip this + // package (with "no" meaning install it even though the + // archive is corrupt), but both options could damage the + // user's system. In the absence of a safe way to recover, we + // just bail out. + if (e->errNo() == APPERR_CORRUPT_PACKAGE) + fatal (owner, IDS_CORRUPT_PACKAGE, version.Name().c_str()); + // Unexpected exception. + throw e; } { md5sum_total_bytes_sofar += version.source()->size;
reply other threads:[~2018-03-22 22:03 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180322220338.19722.qmail@sourceware.org \ --to=jturney@sourceware.org \ --cc=cygwin-apps-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).