public inbox for cygwin-apps-cvs@sourceware.org
help / color / mirror / Atom feed
From: jturney@sourceware.org
To: cygwin-apps-cvs@sourceware.org
Subject: [calm - Cygwin server-side packaging maintenance script] branch master, updated. 20180605-4-gd21631e
Date: Thu, 30 Aug 2018 11:28:00 -0000	[thread overview]
Message-ID: <20180830112850.46652.qmail@sourceware.org> (raw)




https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/calm.git;h=d21631e6a3b2f1f96754735c436fc53ba94b5dcd

commit d21631e6a3b2f1f96754735c436fc53ba94b5dcd
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date:   Thu Aug 30 12:12:51 2018 +0100

    Fix some silent errors when parsing hints fails


Diff:
---
 calm/package.py |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/calm/package.py b/calm/package.py
index 5768224..e9bbe70 100755
--- a/calm/package.py
+++ b/calm/package.py
@@ -185,6 +185,7 @@ def read_package(packages, basedir, dirpath, files, remove=[], upload=False):
         if legacy:
             hints = read_hints(p, os.path.join(dirpath, 'setup.hint'), hint.setup)
             if not hints:
+                logging.error("error parsing %s" % (os.path.join(dirpath, 'setup.hint')))
                 return True
             warnings = clean_hints(p, hints, warnings)
             files.remove('setup.hint')
@@ -198,6 +199,7 @@ def read_package(packages, basedir, dirpath, files, remove=[], upload=False):
             # read override.hint
             override_hints = read_hints(p, os.path.join(dirpath, 'override.hint'), hint.override)
             if not override_hints:
+                logging.error("error parsing %s" % (os.path.join(dirpath, 'override.hint')))
                 return True
             files.remove('override.hint')
         else:
@@ -311,6 +313,7 @@ def read_package(packages, basedir, dirpath, files, remove=[], upload=False):
                 # is there a PVR.hint file?
                 pvr_hint = read_hints(p, os.path.join(dirpath, hint_fn), hint.pvr)
                 if not pvr_hint:
+                    logging.error("error parsing %s" % (os.path.join(dirpath, hint_fn)))
                     return True
                 warnings = clean_hints(p, pvr_hint, warnings)
                 files.remove(hint_fn)


                 reply	other threads:[~2018-08-30 11:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180830112850.46652.qmail@sourceware.org \
    --to=jturney@sourceware.org \
    --cc=cygwin-apps-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).