public inbox for cygwin-apps-cvs@sourceware.org
help / color / mirror / Atom feed
From: jturney@sourceware.org
To: cygwin-apps-cvs@sourceware.org
Subject: [setup - the official Cygwin setup program] branch master, updated. release_2.893-4-g3103d94
Date: Thu, 04 Oct 2018 12:23:00 -0000	[thread overview]
Message-ID: <20181004122304.54751.qmail@sourceware.org> (raw)




https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/setup.git;h=3103d94026056f0ba07548dab8ff9f04f4dccb70

commit 3103d94026056f0ba07548dab8ff9f04f4dccb70
Author: Achim Gratz <Stromeko@Stromeko.DE>
Date:   Tue Jul 31 21:29:02 2018 +0200

    Fix message spam when package vendor is something other than "cygwin"
    
    Installed packages are getting coerced to vendor "cygwin", so there will be
    warnings if the vendor string of the single repo is something other than
    that.


Diff:
---
 package_meta.cc |   15 +++++++++++----
 1 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/package_meta.cc b/package_meta.cc
index f765baf..a7f4cfd 100644
--- a/package_meta.cc
+++ b/package_meta.cc
@@ -183,10 +183,17 @@ packagemeta::add_version (const SolverPool::addPackageData &inpkgdata)
           /* Otherwise... if we had a way to set repo priorities, that could be
              used to control which packageversion the solver picks. For the
              moment, just warn that you might not be getting what you think you
-             should... */
-          Log (LOG_PLAIN) << "Version " << pkgdata.version << " of package " <<
-            name << " is present in releases labelled " << pkgdata.vendor <<
-            " and " << i->Vendor() << endLog;
+             should...
+
+             (suppress this for installed packages, as we are only guessing the
+             vendor, currently)
+          */
+          if (pkgdata.reponame != "_installed")
+            {
+              Log (LOG_PLAIN) << "Version " << pkgdata.version << " of package " <<
+                name << " is present in releases labelled " << pkgdata.vendor <<
+                " and " << i->Vendor() << endLog;
+            }
         }
 
       versions.erase(i);


                 reply	other threads:[~2018-10-04 12:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181004122304.54751.qmail@sourceware.org \
    --to=jturney@sourceware.org \
    --cc=cygwin-apps-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).