From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2201) id 153E5385DC1B; Wed, 15 Apr 2020 17:00:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 153E5385DC1B To: cygwin-apps-cvs@sourceware.org Subject: [calm - Cygwin server-side packaging maintenance script] branch master, updated. 20200401-12-gd047fed X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 66ccbbe56e49d4c92fafd28ba1ef42e4beea8712 X-Git-Newrev: d047fed3d38af7a0307f46d74b0bf7e78eaaeda6 Message-Id: <20200415170039.153E5385DC1B@sourceware.org> Date: Wed, 15 Apr 2020 17:00:39 +0000 (GMT) From: Jon TURNEY X-BeenThere: cygwin-apps-cvs@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin-apps git logs List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2020 17:00:39 -0000 https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/calm.git;h=d047fed3d38af7a0307f46d74b0bf7e78eaaeda6 commit d047fed3d38af7a0307f46d74b0bf7e78eaaeda6 Author: Jon Turney Date: Wed Apr 15 17:11:54 2020 +0100 Change From: address to cygwin-apps Change From: address to cygwin-apps list, so bounces and replies go there. https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/calm.git;h=241c7f410e624774156aec82add9962875d3d038 commit 241c7f410e624774156aec82add9962875d3d038 Author: Jon Turney Date: Wed Apr 15 14:57:39 2020 +0100 Also set the envelope-from for mails we send This should avoid mails being sent out with an envelope-from of cygwin@cygwin.com, which leads to bounces arriving on our main mailing list. (Sending bounces to cygwin-no-reply is suboptimal, as it means we don't know when somethings going wrong with our mail delivery) Diff: --- calm/buffering_smtp_handler.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/calm/buffering_smtp_handler.py b/calm/buffering_smtp_handler.py index 9d347df..a590b8b 100644 --- a/calm/buffering_smtp_handler.py +++ b/calm/buffering_smtp_handler.py @@ -35,7 +35,7 @@ class BufferingSMTPHandler(logging.handlers.BufferingHandler): toaddrs, subject, mailhost=common_constants.MAILHOST, - fromaddr='cygwin-no-reply@cygwin.com', + fromaddr='cygwin-apps@cygwin.com', logging_format='%(levelname)s: %(message)s'): logging.handlers.BufferingHandler.__init__(self, capacity=0) self.mailhost = mailhost @@ -85,7 +85,7 @@ class BufferingSMTPHandler(logging.handlers.BufferingHandler): print(msg) print('-' * 40) elif len(self.toaddrs) > 0: - with subprocess.Popen(['/usr/sbin/sendmail', '-t', '-oi'], stdin=subprocess.PIPE) as p: + with subprocess.Popen(['/usr/sbin/sendmail', '-t', '-oi', '-f', self.fromaddr], stdin=subprocess.PIPE) as p: p.communicate(m.as_bytes()) self.buffer = []