public inbox for cygwin-apps-cvs@sourceware.org help / color / mirror / Atom feed
From: Jon TURNEY <jturney@sourceware.org> To: cygwin-apps-cvs@sourceware.org Subject: [calm - Cygwin server-side packaging maintenance script] branch master, updated. 20200401-27-gc9b5ce5 Date: Mon, 25 May 2020 18:06:56 +0000 (GMT) [thread overview] Message-ID: <20200525180656.455E0388E83D@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/calm.git;h=c9b5ce5b9352bd575200a9a675fca61c1b6bf429 commit c9b5ce5b9352bd575200a9a675fca61c1b6bf429 Author: Jon Turney <jon.turney@dronecode.org.uk> Date: Mon May 25 16:28:59 2020 +0100 Consider versions overriden by version: when checking if a hint is stale When uploading a replacement hint with a version: override, the overriden version doesn't exist anymore, so the hint will be considered stale and removed. This causes the upload to fail as movelist validation notices that the hint is both uploaded and automatically vaulted. Diff: --- calm/package.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/calm/package.py b/calm/package.py index 487c3ed..66d03df 100755 --- a/calm/package.py +++ b/calm/package.py @@ -394,6 +394,8 @@ def read_one_package(packages, p, relpath, dirpath, files, remove, kind): # apply a version override if 'version' in pvr_hint: ovr = pvr_hint['version'] + # also record the version before the override + pvr_hint['original-version'] = vr else: ovr = vr @@ -1411,8 +1413,9 @@ def stale_packages(packages): for v in po.hints: # if there's a pvr.hint without a fresh source or install of the - # same version, move it as well - if all_stale.get(v, True): + # same version (including version: overrides), move it as well + ov = po.hints[v].hints.get('original-version', v) + if all_stale.get(v, True) and all_stale.get(ov, True): stale.add(po.hints[v].path, po.hints[v].fn) logging.debug("package '%s' version '%s' hint is stale" % (pn, v))
reply other threads:[~2020-05-25 18:06 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200525180656.455E0388E83D@sourceware.org \ --to=jturney@sourceware.org \ --cc=cygwin-apps-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).