public inbox for
help / color / mirror / Atom feed
* [calm - Cygwin server-side packaging maintenance script] branch master, updated. 20200401-27-gc9b5ce5
@ 2020-05-25 18:06 Jon TURNEY
  0 siblings, 0 replies; only message in thread
From: Jon TURNEY @ 2020-05-25 18:06 UTC (permalink / raw)
  To: cygwin-apps-cvs;h=c9b5ce5b9352bd575200a9a675fca61c1b6bf429

commit c9b5ce5b9352bd575200a9a675fca61c1b6bf429
Author: Jon Turney <>
Date:   Mon May 25 16:28:59 2020 +0100

    Consider versions overriden by version: when checking if a hint is stale
    When uploading a replacement hint with a version: override, the overriden
    version doesn't exist anymore, so the hint will be considered stale and
    This causes the upload to fail as movelist validation notices that the
    hint is both uploaded and automatically vaulted.

 calm/ | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/calm/ b/calm/
index 487c3ed..66d03df 100755
--- a/calm/
+++ b/calm/
@@ -394,6 +394,8 @@ def read_one_package(packages, p, relpath, dirpath, files, remove, kind):
         # apply a version override
         if 'version' in pvr_hint:
             ovr = pvr_hint['version']
+            # also record the version before the override
+            pvr_hint['original-version'] = vr
             ovr = vr
@@ -1411,8 +1413,9 @@ def stale_packages(packages):
         for v in po.hints:
             # if there's a pvr.hint without a fresh source or install of the
-            # same version, move it as well
-            if all_stale.get(v, True):
+            # same version (including version: overrides), move it as well
+            ov = po.hints[v].hints.get('original-version', v)
+            if all_stale.get(v, True) and all_stale.get(ov, True):
                 stale.add(po.hints[v].path, po.hints[v].fn)
                 logging.debug("package '%s' version '%s' hint is stale" % (pn, v))

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-25 18:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-25 18:06 [calm - Cygwin server-side packaging maintenance script] branch master, updated. 20200401-27-gc9b5ce5 Jon TURNEY

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).