public inbox for cygwin-apps-cvs@sourceware.org help / color / mirror / Atom feed
From: Jon TURNEY <jturney@sourceware.org> To: cygwin-apps-cvs@sourceware.org Subject: [calm - Cygwin server-side packaging maintenance script] branch master, updated. 20210408-14-gfd03d0e Date: Mon, 17 May 2021 14:33:50 +0000 (GMT) [thread overview] Message-ID: <20210517143350.BF754384607B@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/calm.git;h=fd03d0e762498b21ed7ac53b09feae2372faadb0 commit fd03d0e762498b21ed7ac53b09feae2372faadb0 Author: Jon Turney <jon.turney@dronecode.org.uk> Date: Mon May 17 14:57:22 2021 +0100 Fix a crash when all versions of a package are getting removed > Traceback (most recent call last): > File "/sourceware1/cygwin-staging/calm/calm/calm.py", line 578, in do_daemon > state.packages = process_uploads(args, state) > File "/sourceware1/cygwin-staging/calm/calm/calm.py", line 190, in process_uploads > if not package.validate_packages(args, merged_packages[arch]): > File "/sourceware1/cygwin-staging/calm/calm/package.py", line 844, in validate_packages > if any(['_obsolete' in packages[install_p].version_hints[vr].get('category', '') for vr in packages[install_p].version_hints]): > KeyError: 'amd' Diff: --- calm/package.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/calm/package.py b/calm/package.py index 9c47f47..1e5b0f1 100755 --- a/calm/package.py +++ b/calm/package.py @@ -840,6 +840,10 @@ def validate_packages(args, packages): versions = defaultdict(list) for install_p in packages[source_p].is_used_by: + # ignore package which are getting removed + if install_p not in packages: + continue + # ignore obsolete packages if any(['_obsolete' in packages[install_p].version_hints[vr].get('category', '') for vr in packages[install_p].version_hints]): continue
reply other threads:[~2021-05-17 14:33 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210517143350.BF754384607B@sourceware.org \ --to=jturney@sourceware.org \ --cc=cygwin-apps-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).