public inbox for cygwin-apps-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jon TURNEY <jturney@sourceware.org>
To: cygwin-apps-cvs@sourceware.org
Subject: [setup - the official Cygwin setup program] branch master, updated. release_2.912
Date: Fri, 31 Dec 2021 14:05:16 +0000 (GMT)	[thread overview]
Message-ID: <20211231140516.26E0C3858D37@sourceware.org> (raw)




https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/setup.git;h=beaffbbd8f5738b2c9f87cf9bfb1208b49763869

commit beaffbbd8f5738b2c9f87cf9bfb1208b49763869
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date:   Fri Dec 31 00:25:56 2021 +0000

    Fix SeCreateSymbolicLinkPrivilege detection
    
    SeCreateSymbolicLinkPrivilege is enabled automatically on use, so it
    only needs to be present in the token, not enabled.

https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/setup.git;h=7850e95810f57c136f57098ab91dfec307928b50

commit 7850e95810f57c136f57098ab91dfec307928b50
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date:   Thu Dec 30 23:19:06 2021 +0000

    Fix inverted symlink creation right logging


Diff:
---
 win32.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/win32.cc b/win32.cc
index 35a28c6b..a403d662 100644
--- a/win32.cc
+++ b/win32.cc
@@ -322,7 +322,7 @@ NTSecurity::setDefaultSecurity (bool isAdmin)
   setBackupPrivileges ();
 
   /* Log if symlink creation privilege is available. */
-  if (hasSymlinkCreationRights())
+  if (!hasSymlinkCreationRights())
     Log (LOG_TIMESTAMP) << "User has NO symlink creation right" << endLog;
   else
     Log (LOG_TIMESTAMP) << "User has symlink creation right" << endLog;
@@ -404,7 +404,7 @@ NTSecurity::hasSymlinkCreationRights ()
     {
       if (memcmp(&privileges->Privileges[i].Luid, &symlink, sizeof(LUID)) == 0)
         {
-          return (privileges->Privileges[i].Attributes & SE_PRIVILEGE_ENABLED);
+          return TRUE;
         }
     }
 



                 reply	other threads:[~2021-12-31 14:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211231140516.26E0C3858D37@sourceware.org \
    --to=jturney@sourceware.org \
    --cc=cygwin-apps-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).