public inbox for cygwin-apps-cvs@sourceware.org
help / color / mirror / Atom feed
* [setup - the official Cygwin setup program] branch master, updated. release_2.912
@ 2021-12-31 14:05 Jon TURNEY
0 siblings, 0 replies; only message in thread
From: Jon TURNEY @ 2021-12-31 14:05 UTC (permalink / raw)
To: cygwin-apps-cvs
https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/setup.git;h=beaffbbd8f5738b2c9f87cf9bfb1208b49763869
commit beaffbbd8f5738b2c9f87cf9bfb1208b49763869
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date: Fri Dec 31 00:25:56 2021 +0000
Fix SeCreateSymbolicLinkPrivilege detection
SeCreateSymbolicLinkPrivilege is enabled automatically on use, so it
only needs to be present in the token, not enabled.
https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/setup.git;h=7850e95810f57c136f57098ab91dfec307928b50
commit 7850e95810f57c136f57098ab91dfec307928b50
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date: Thu Dec 30 23:19:06 2021 +0000
Fix inverted symlink creation right logging
Diff:
---
win32.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/win32.cc b/win32.cc
index 35a28c6b..a403d662 100644
--- a/win32.cc
+++ b/win32.cc
@@ -322,7 +322,7 @@ NTSecurity::setDefaultSecurity (bool isAdmin)
setBackupPrivileges ();
/* Log if symlink creation privilege is available. */
- if (hasSymlinkCreationRights())
+ if (!hasSymlinkCreationRights())
Log (LOG_TIMESTAMP) << "User has NO symlink creation right" << endLog;
else
Log (LOG_TIMESTAMP) << "User has symlink creation right" << endLog;
@@ -404,7 +404,7 @@ NTSecurity::hasSymlinkCreationRights ()
{
if (memcmp(&privileges->Privileges[i].Luid, &symlink, sizeof(LUID)) == 0)
{
- return (privileges->Privileges[i].Attributes & SE_PRIVILEGE_ENABLED);
+ return TRUE;
}
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-12-31 14:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-31 14:05 [setup - the official Cygwin setup program] branch master, updated. release_2.912 Jon TURNEY
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).