https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/calm.git;h=2ff605868c0b99afe059767602b07f5522c47c8e commit 2ff605868c0b99afe059767602b07f5522c47c8e Author: Jon Turney <jon.turney@dronecode.org.uk> Date: Sun Feb 12 18:59:37 2023 +0000 Fix reports https://sourceware.org/git/gitweb.cgi?p=cygwin-apps/calm.git;h=59016dd9b0fbf0819ca79c2afff033797c8e9fba commit 59016dd9b0fbf0819ca79c2afff033797c8e9fba Author: Jon Turney <jon.turney@dronecode.org.uk> Date: Sun Feb 12 17:59:50 2023 +0000 Fix mkgitolite for maintainers rewrite Keep maintainers in a list, not a set, because we need "first named maintainer". Diff: --- calm/mkgitoliteconf.py | 6 ++++-- calm/reports.py | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/calm/mkgitoliteconf.py b/calm/mkgitoliteconf.py index 3b8ab73..cf416ba 100755 --- a/calm/mkgitoliteconf.py +++ b/calm/mkgitoliteconf.py @@ -85,8 +85,10 @@ def do_main(args): print("repo git/cygwin-packages/%s" % (p)) print("C = %s @leads" % (users)) - print("RW master$ = %s" % (users)) - print("RW refs/tags/ = %s" % (users)) + if users: + # this won't be syntactically correct if users is empty + print("RW master$ = %s" % (users)) + print("RW refs/tags/ = %s" % (users)) print("owner = %s" % (owner)) print("") diff --git a/calm/reports.py b/calm/reports.py index c2fac58..43b9030 100644 --- a/calm/reports.py +++ b/calm/reports.py @@ -77,7 +77,7 @@ def unmaintained(args, packages, reportsdir): if po.kind != package.Kind.source: continue - if not pkg_maintainers[po.orig_name].is_orphaned(): + if (po.orig_name not in pkg_maintainers) or (not pkg_maintainers[po.orig_name].is_orphaned()): continue # the highest version we have