From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37412 invoked by alias); 25 Dec 2017 19:18:32 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 37399 invoked by uid 89); 25 Dec 2017 19:18:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Side, BEGIN, 5479, 5908 X-HELO: limerock02.mail.cornell.edu Received: from limerock02.mail.cornell.edu (HELO limerock02.mail.cornell.edu) (128.84.13.242) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Dec 2017 19:18:29 +0000 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id vBPJIRgb006297 for ; Mon, 25 Dec 2017 14:18:27 -0500 Received: from [192.168.0.15] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id vBPJIPBu018401 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Mon, 25 Dec 2017 14:18:26 -0500 Subject: Re: setup libsolv UI: Silently install dependencies? To: cygwin-apps@cygwin.com References: <053865d5-650a-ad79-e91e-4a047e09cb9d@cornell.edu> From: Ken Brown Message-ID: <00021c1d-57a0-1344-9a28-6081c6c1255e@cornell.edu> Date: Mon, 25 Dec 2017 19:18:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <053865d5-650a-ad79-e91e-4a047e09cb9d@cornell.edu> Content-Type: multipart/mixed; boundary="------------ECBDDB1C35BA5CFC73BCB895" X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00088.txt.bz2 This is a multi-part message in MIME format. --------------ECBDDB1C35BA5CFC73BCB895 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-length: 1074 On 12/24/2017 6:23 PM, Ken Brown wrote: > Currently the libsolv version of setup silently installs added > dependencies.  The user gets a chance to review them first only if > libsolv finds problems and has to display the prerequisite page. > > I'm not sure if this was a deliberate design decision, though I > personally like it.  On the other hand, I suspect that some users won't > like it because they're used to seeing a report about missing > dependencies.  So I think we should make this behavior optional. > > The attached patch is a start in that direction.  But it needs a > followup patch to implement the mechanism for selecting the option.  One > possibility is a checkbox on the chooser page, which then gets saved in > setup.rc as a user option. And here's a followup patch that implements that possibility. [Side comment: Jon, in v2 of commit 9367283, you removed some newlines, saying that they weren't needed because wrapping would be done. But I'm not seeing that wrapping; I have to scroll horizontally to see the whole text.] Ken --------------ECBDDB1C35BA5CFC73BCB895 Content-Type: text/plain; charset=UTF-8; name="0001-Implement-user-option-to-report-added-dependencies.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Implement-user-option-to-report-added-dependencies.patc"; filename*1="h" Content-length: 6995 RnJvbSBmM2FhZGZlYWQ0OWY5ZWMxN2YwNGUwMDUxZDZkNThmNjE5YzUwOTJi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZW4gQnJvd24gPGti cm93bkBjb3JuZWxsLmVkdT4KRGF0ZTogTW9uLCAyNSBEZWMgMjAxNyAxNDow NDoyMCAtMDUwMApTdWJqZWN0OiBbUEFUQ0ggc2V0dXAgbGlic29sdl0gSW1w bGVtZW50IHVzZXIgb3B0aW9uIHRvIHJlcG9ydCBhZGRlZAogZGVwZW5kZW5j aWVzCgpBZGQgYSBjaGVja2JveCBJRENfQ0hPT1NFX1JFUE9SVCB0byBJRERf Q0hPT1NFX0RJQUxPRyB0aGF0IGRldGVybWluZXMKdGhlIHZhbHVlIG9mIFBy ZXJlcUNoZWNrZXI6OnJlcG9ydF9hZGRlZF9kZXBzLiAgU2F2ZSB0aGUgdXNl cidzIGNob2ljZQppbiBhIG5ldyB1c2VyIHNldHRpbmcgInJlcG9ydF91c2Vy X2RlcHMiLgotLS0KIGNob29zZS5jYyAgfCAxNCArKysrKysrKysrKysrKwog cHJlcmVxLmNjICB8ICAyICstCiBwcmVyZXEuaCAgIHwgIDIgKysKIHJlcy5y YyAgICAgfCAgNCArKysrCiByZXNvdXJjZS5oIHwgIDIgKysKIDUgZmlsZXMg Y2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlm ZiAtLWdpdCBhL2Nob29zZS5jYyBiL2Nob29zZS5jYwppbmRleCBmZjU3ZDg1 Li5kNWU1NWI4IDEwMDY0NAotLS0gYS9jaG9vc2UuY2MKKysrIGIvY2hvb3Nl LmNjCkBAIC04Myw2ICs4Myw3IEBAIHN0YXRpYyBDb250cm9sQWRqdXN0ZXI6 OkNvbnRyb2xJbmZvIENob29zZXJDb250cm9sc0luZm9bXSA9IHsKICAge0lE Q19DSE9PU0VfVklFV0NBUFRJT04sCUNQX0xFRlQsICAgIENQX1RPUH0sCiAg IHtJRENfQ0hPT1NFX0xJU1QsCQlDUF9TVFJFVENILCBDUF9TVFJFVENIfSwK ICAge0lEQ19DSE9PU0VfSElERSwgICAgICAgICAgICAgQ1BfTEVGVCwgICAg Q1BfQk9UVE9NfSwKKyAge0lEQ19DSE9PU0VfUkVQT1JULCAgICAgICAgICAg Q1BfTEVGVCwgICAgQ1BfQk9UVE9NfSwKICAgezAsIENQX0xFRlQsIENQX1RP UH0KIH07CiAKQEAgLTEyOCw2ICsxMjksOCBAQCBDaG9vc2VyUGFnZTo6fkNo b29zZXJQYWdlICgpCiAJfQogICAgICAgVXNlclNldHRpbmdzOjppbnN0YW5j ZSgpLnNldCAoImNob29zZXJfd2luZG93X3NldHRpbmdzIiwgdG9zZXQpOwog ICAgIH0KKyAgVXNlclNldHRpbmdzOjppbnN0YW5jZSgpLnNldCAoInJlcG9y dF9hZGRlZF9kZXBzIiwKKwkJCQlQcmVyZXFDaGVja2VyOjpyZXBvcnRBZGRl ZERlcHMgKCkgPyAieWVzIiA6ICJubyIpOwogfQogCiB2b2lkCkBAIC0yNTUs NiArMjU4LDEzIEBAIENob29zZXJQYWdlOjpPbkluaXQgKCkKIHsKICAgQ2hl Y2tEbGdCdXR0b24gKEdldEhXTkQgKCksIElEQ19DSE9PU0VfSElERSwgQlNU X0NIRUNLRUQpOwogCisgIGNvbnN0IGNoYXIgKmZnX3JldCA9CisgICAgVXNl clNldHRpbmdzOjppbnN0YW5jZSgpLmdldCAoInJlcG9ydF9hZGRlZF9kZXBz Iik7CisgIGJvb2wgcmVwb3J0X2FkZGVkX2RlcHMgPSAhZmdfcmV0IHx8IHN0 cmNtcCAoZmdfcmV0LCAibm8iICkgIT0gMDsKKyAgUHJlcmVxQ2hlY2tlcjo6 c2V0QWRkZWREZXBzIChyZXBvcnRfYWRkZWRfZGVwcyk7CisgIENoZWNrRGxn QnV0dG9uIChHZXRIV05EICgpLCBJRENfQ0hPT1NFX1JFUE9SVCwKKwkJICBy ZXBvcnRfYWRkZWRfZGVwcyA/IEJTVF9DSEVDS0VEIDogQlNUX1VOQ0hFQ0tF RCk7CisKICAgLyogUG9wdWxhdGUgdmlldyBkcm9wZG93biBsaXN0IHdpdGgg Y2hvaWNlcyAqLwogICBIV05EIHZpZXdsaXN0ID0gR2V0RGxnSXRlbSAoSURD X0NIT09TRV9WSUVXKTsKICAgU2VuZE1lc3NhZ2UgKHZpZXdsaXN0LCBDQl9S RVNFVENPTlRFTlQsIDAsIDApOwpAQCAtMjc5LDYgKzI4OSw3IEBAIENob29z ZXJQYWdlOjpPbkluaXQgKCkKICAgQWRkVG9vbHRpcCAoSURDX0NIT09TRV9W SUVXLCBJRFNfVklFV0JVVFRPTl9UT09MVElQKTsKICAgQWRkVG9vbHRpcCAo SURDX0NIT09TRV9ISURFLCBJRFNfSElERU9CU19UT09MVElQKTsKICAgQWRk VG9vbHRpcCAoSURDX0NIT09TRV9TRUFSQ0hfRURJVCwgSURTX1NFQVJDSF9U T09MVElQKTsKKyAgQWRkVG9vbHRpcCAoSURDX0NIT09TRV9SRVBPUlQsIElE U19SRVBPUlRERVBTX1RPT0xUSVApOwogCiAgIC8qIFNldCBmb2N1cyB0byBz ZWFyY2ggZWRpdHRleHQgY29udHJvbC4gKi8KICAgUG9zdE1lc3NhZ2UgKEdl dEhXTkQgKCksIFdNX05FWFRETEdDVEwsCkBAIC01MzYsNiArNTQ3LDkgQEAg Q2hvb3NlclBhZ2U6Ok9uTWVzc2FnZUNtZCAoaW50IGlkLCBIV05EIGh3bmRj dGwsIFVJTlQgY29kZSkKICAgICBjYXNlIElEQ19DSE9PU0VfSElERToKICAg ICAgIGNob29zZXItPnNldE9ic29sZXRlICghSXNCdXR0b25DaGVja2VkIChp ZCkpOwogICAgICAgYnJlYWs7CisgICAgY2FzZSBJRENfQ0hPT1NFX1JFUE9S VDoKKyAgICAgIFByZXJlcUNoZWNrZXI6OnNldEFkZGVkRGVwcyAoSXNCdXR0 b25DaGVja2VkIChpZCkpOworICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoK ICAgICAgIC8vIFdhc24ndCByZWNvZ25pemVkIG9yIGhhbmRsZWQuCiAgICAg ICByZXR1cm4gZmFsc2U7CmRpZmYgLS1naXQgYS9wcmVyZXEuY2MgYi9wcmVy ZXEuY2MKaW5kZXggMGMwNmEzMi4uMjMxZTZkYyAxMDA2NDQKLS0tIGEvcHJl cmVxLmNjCisrKyBiL3ByZXJlcS5jYwpAQCAtMTU5LDcgKzE1OSw3IEBAIFBy ZXJlcVBhZ2U6Ok9uVW5hdHRlbmRlZCAoKQogCiAvLyBpbnN0YW50aWF0ZSB0 aGUgc3RhdGljIG1lbWJlcnMKIGJvb2wgUHJlcmVxQ2hlY2tlcjo6dXNlX3Rl c3RfcGFja2FnZXM7Ci1ib29sIFByZXJlcUNoZWNrZXI6OnJlcG9ydF9hZGRl ZF9kZXBzID0gdHJ1ZTsKK2Jvb2wgUHJlcmVxQ2hlY2tlcjo6cmVwb3J0X2Fk ZGVkX2RlcHM7CiAKIHN0YXRpYyBib29sCiBhZGRlZF9kZXBzICgpCmRpZmYg LS1naXQgYS9wcmVyZXEuaCBiL3ByZXJlcS5oCmluZGV4IGExNDc4OWEuLmM3 OWQzMDYgMTAwNjQ0Ci0tLSBhL3ByZXJlcS5oCisrKyBiL3ByZXJlcS5oCkBA IC00MSw2ICs0MSw4IEBAIHB1YmxpYzoKICAgdm9pZCBnZXRVbm1ldFN0cmlu ZyAoc3RkOjpzdHJpbmcgJnMpOwogCiAgIHN0YXRpYyB2b2lkIHNldFRlc3RQ YWNrYWdlcyAoYm9vbCB0KSB7IHVzZV90ZXN0X3BhY2thZ2VzID0gdDsgfTsK KyAgc3RhdGljIHZvaWQgc2V0QWRkZWREZXBzIChib29sIHQpIHsgcmVwb3J0 X2FkZGVkX2RlcHMgPSB0OyB9OworICBzdGF0aWMgYm9vbCByZXBvcnRBZGRl ZERlcHMgKCkgeyByZXR1cm4gcmVwb3J0X2FkZGVkX2RlcHM7IH07CiAKIHBy aXZhdGU6CiAgIHN0YXRpYyBib29sIHVzZV90ZXN0X3BhY2thZ2VzOwpkaWZm IC0tZ2l0IGEvcmVzLnJjIGIvcmVzLnJjCmluZGV4IGVlNDI3MGEuLjdkMGRl NzkgMTAwNjQ0Ci0tLSBhL3Jlcy5yYworKysgYi9yZXMucmMKQEAgLTM2Myw2 ICszNjMsOCBAQCBCRUdJTgogICAgICAgICAgICAgICAgICAgICBXU19WSVNJ QkxFLCA3LCA0NSwgU0VUVVBfU1RBTkRBUkRfRElBTE9HX1cgLSAxNCwgMTIy CiAgICAgQ09OVFJPTCAgICAgICAgICImSGlkZSBvYnNvbGV0ZSBwYWNrYWdl cyIsIElEQ19DSE9PU0VfSElERSwKICAgICAgICAgICAgICAgICAgICAgIkJ1 dHRvbiIsIEJTX0FVVE9DSEVDS0JPWCB8IFdTX1RBQlNUT1AsIDcsIDE2Nywg MTYwLCAxNAorICAgIENPTlRST0wgICAgICAgICAiJlJlcG9ydCBhZGRlZCBk ZXBlbmRlbmNpZXMiLCBJRENfQ0hPT1NFX1JFUE9SVCwKKyAgICAgICAgICAg ICAgICAgICAgIkJ1dHRvbiIsIEJTX0FVVE9DSEVDS0JPWCB8IFdTX1RBQlNU T1AsIDE2NywgMTY3LCAxNjAsIDE0CiAgICAgSUNPTiAgICAgICAgICAgIElE SV9DWUdXSU4sIElEQ19IRUFESUNPTiwgU0VUVVBfSEVBRElDT05fWCwgMCwg MjEsIDIwCiAgICAgTFRFWFQgICAgICAgICAgICJTZWxlY3QgdGhlIHBhY2th Z2VzIHlvdSB3YW50IHNldHVwIHRvIGluc3RhbGwuIiwKICAgICAgICAgICAg ICAgICAgICAgSURDX0NIT09TRV9JTlNUX1RFWFQsIDIxLCA5LCAyMzksIDE2 LCBOT1QgV1NfR1JPVVAKQEAgLTU4OCw2ICs1OTAsOCBAQCBCRUdJTgogICAg ICAgICJ3aXRoIG5hbWVzIHRoYXQgYmVnaW4gd2l0aCAnXycuICBTdWNoIHBh Y2thZ2VzIGFyZSB1c3VhbGx5IGVtcHR5ICIKICAgICAgICAicGxhY2Vob2xk ZXJzIGZvciBwYWNrYWdlcyB0aGF0IGhhdmUgYmVlbiByZW1vdmVkIG9yIHJl bmFtZWQsIG9yIGFyZSAiCiAgICAgICAgImluZnJhc3RydWN0dXJlIHBhY2th Z2VzIHRoYXQgYXJlIGhhbmRsZWQgYXV0b21hdGljYWxseS4iCisgICAgSURT X1JFUE9SVERFUFNfVE9PTFRJUCAiSWYgcGFja2FnZXMgYXJlIGFkZGVkIHRv IHNhdGlzZnkgZGVwZW5kZW5jaWVzLCAiCisgICAgICAgInBhdXNlIHRvIGFs bG93IHJldmlldyBvZiB0aGVtLiIKICAgICBJRFNfU0lHX0lOVkFMSUQgICAg Ik1pcnJvciBFcnJvcjogIFNldHVwLmluaSBzaWduYXR1cmUgJXMgZnJvbSAl cyBmYWlsZWQgdG8gdmVyaWZ5LlxuUG9zc2libGUgY29ycnVwdCBtaXJyb3I/ ICBTZXR1cC5pbmkgcmVqZWN0ZWQuIgogICAgIElEU19DUllQVE9fRVJST1Ig ICAiSW50ZXJuYWwgRXJyb3I6ICBnY3J5cHQgbGlicmFyeSBlcnJvciAlZCAl cyIKICAgICBJRFNfU0VBUkNIX1RPT0xUSVAgIlNlYXJjaCBmb3IgdGhpcyBz dHJpbmcgaW4gcGFja2FnZSBuYW1lcy4iCmRpZmYgLS1naXQgYS9yZXNvdXJj ZS5oIGIvcmVzb3VyY2UuaAppbmRleCBlMzg1YzllLi43M2NmMDZjIDEwMDY0 NAotLS0gYS9yZXNvdXJjZS5oCisrKyBiL3Jlc291cmNlLmgKQEAgLTQwLDYg KzQwLDcgQEAKICNkZWZpbmUgSURTX0lOU1RBTExFREJfVkVSU0lPTiAgICAg ICAgICAgIDE0MAogI2RlZmluZSBJRFNfRE9XTkxPQURfSU5DT01QTEVURV9F WElUICAgICAgMTQxCiAjZGVmaW5lIElEU19UUlVTVFNZTkNfVE9PTFRJUCAg ICAgICAgICAgICAxNDIKKyNkZWZpbmUgSURTX1JFUE9SVERFUFNfVE9PTFRJ UCAgICAgICAgICAgIDE0MwogCiAvLyBEaWFsb2dzCiAKQEAgLTE4MCwzICsx ODEsNCBAQAogI2RlZmluZSBJRENfRE9XTkxPQURfRURJVCAgICAgICAgICAg ICAgICAgNTk0CiAjZGVmaW5lIElEQ19DSE9PU0VfRE9fU0VBUkNIICAgICAg ICAgICAgICA1OTUKICNkZWZpbmUgSURDX0NIT09TRV9TWU5DICAgICAgICAg ICAgICAgICAgIDU5NgorI2RlZmluZSBJRENfQ0hPT1NFX1JFUE9SVCAgICAg ICAgICAgICAgICAgNTk3Ci0tIAoyLjE1LjEKCg== --------------ECBDDB1C35BA5CFC73BCB895--