From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61198 invoked by alias); 17 Oct 2017 12:45:03 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 60759 invoked by uid 89); 17 Oct 2017 12:45:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Stability, Hx-languages-length:3353 X-HELO: limerock04.mail.cornell.edu Received: from limerock04.mail.cornell.edu (HELO limerock04.mail.cornell.edu) (128.84.13.244) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Oct 2017 12:44:59 +0000 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id v9HCiul0020515 for ; Tue, 17 Oct 2017 08:44:57 -0400 Received: from [192.168.0.15] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id v9HCit6A002313 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Tue, 17 Oct 2017 08:44:56 -0400 Subject: Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP) To: cygwin-apps@cygwin.com References: <20170531105015.162228-1-jon.turney@dronecode.org.uk> <488ba627-de58-ddc7-7f69-696adae76b8a@cornell.edu> <9bcf50cf-81bc-c9d1-3ac3-b7e1a3522045@dronecode.org.uk> <5441628f-a99a-1611-616a-da98ea9a0e12@cornell.edu> <7044db65-8b6e-6bf6-a079-99397917ce43@cornell.edu> <8e655423-ef53-3aeb-3d6c-de5021d3bd87@dronecode.org.uk> <5e74cacd-3153-1561-3cd2-5ece0e35a2d2@cornell.edu> From: Ken Brown Message-ID: <003a8566-ad2b-a962-725a-4384fd5e4c64@cornell.edu> Date: Tue, 17 Oct 2017 12:45:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------3732D1967879F1C962D74ADC" X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00065.txt.bz2 This is a multi-part message in MIME format. --------------3732D1967879F1C962D74ADC Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 739 On 10/10/2017 7:18 AM, Ken Brown wrote: > On 9/29/2017 4:33 PM, Ken Brown wrote: >> I'll resume my testing after I return. > > I've just started testing (based on the current HEAD of topic/libsolv), > and so far everything looks good. I came across a situation where a SolvableVersion method was being called on a trivial object (with pool and id both 0). This caused a crash when pool_id2solvable(pool, id) was called and pool was dereferenced. There's probably a bug that led to this situation. [It involved a local install in which a package was listed in two different setup.ini files, but the tarballs existed only in one.] I plan to investigate this further. But in any case, we shouldn't crash. Patch attached. Ken --------------3732D1967879F1C962D74ADC Content-Type: text/plain; charset=UTF-8; name="0001-Avoid-dereferencing-NULL-pointers.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Avoid-dereferencing-NULL-pointers.patch" Content-length: 3640 RnJvbSBmM2IzYzYwZWQ0NzNhMWVmNGU1YjFhZTVmY2QxYmZjNDZhNjIxMGZi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZW4gQnJvd24gPGti cm93bkBjb3JuZWxsLmVkdT4KRGF0ZTogVHVlLCAxNyBPY3QgMjAxNyAwODox Mjo0OCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIEF2b2lkIGRlcmVmZXJlbmNp bmcgTlVMTCBwb2ludGVycwoKVGhlIGxpYnNvbHYgZnVuY3Rpb24gcG9vbF9p ZDJzb2x2YWJsZSB1bmNvbmRpdGlvbmFsbHkgZGVyZWZlcmVuY2VzIGl0cwpm aXJzdCBhcmd1bWVudCAoJ3Bvb2wnKS4gIENhbGxlcnMgbXVzdCBjaGVjayB0 aGF0IHRoaXMgYXJndW1lbnQgaXMKbm9uLU5VTEwgdG8gYXZvaWQgY3Jhc2hl cy4KLS0tCiBsaWJzb2x2LmNjIHwgMTYgKysrKysrKysrKysrKysrLQogMSBm aWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK CmRpZmYgLS1naXQgYS9saWJzb2x2LmNjIGIvbGlic29sdi5jYwppbmRleCA3 OGU3M2E4Li4zYTI0NGQ0IDEwMDY0NAotLS0gYS9saWJzb2x2LmNjCisrKyBi L2xpYnNvbHYuY2MKQEAgLTc1LDYgKzc1LDggQEAgUmVsSWQyT3BlcmF0b3Io SWQgaWQpCiBjb25zdCBzdGQ6OnN0cmluZwogU29sdmFibGVWZXJzaW9uOjpO YW1lICgpIGNvbnN0CiB7CisgIGlmICghcG9vbCkKKyAgICByZXR1cm4gIiI7 CiAgIFNvbHZhYmxlICpzb2x2YWJsZSA9IHBvb2xfaWQyc29sdmFibGUocG9v bCwgaWQpOwogICByZXR1cm4gc3RkOjpzdHJpbmcocG9vbF9pZDJzdHIocG9v bCwgc29sdmFibGUtPm5hbWUpKTsKIH0KQEAgLTgyLDYgKzg0LDggQEAgU29s dmFibGVWZXJzaW9uOjpOYW1lICgpIGNvbnN0CiBjb25zdCBzdGQ6OnN0cmlu ZwogU29sdmFibGVWZXJzaW9uOjpDYW5vbmljYWxfdmVyc2lvbigpIGNvbnN0 CiB7CisgIGlmICghcG9vbCkKKyAgICByZXR1cm4gIiI7CiAgIFNvbHZhYmxl ICpzb2x2YWJsZSA9IHBvb2xfaWQyc29sdmFibGUocG9vbCwgaWQpOwogICBy ZXR1cm4gc3RkOjpzdHJpbmcocG9vbF9pZDJzdHIocG9vbCwgc29sdmFibGUt PmV2cikpOwogfQpAQCAtODksNiArOTMsOCBAQCBTb2x2YWJsZVZlcnNpb246 OkNhbm9uaWNhbF92ZXJzaW9uKCkgY29uc3QKIHBhY2thZ2VfdHlwZV90CiBT b2x2YWJsZVZlcnNpb246OlR5cGUgKCkgY29uc3QKIHsKKyAgaWYgKCFwb29s KQorICAgIHJldHVybiBwYWNrYWdlX2JpbmFyeTsKICAgU29sdmFibGUgKnNv bHZhYmxlID0gcG9vbF9pZDJzb2x2YWJsZShwb29sLCBpZCk7CiAgIGlmIChz b2x2YWJsZS0+YXJjaCA9PSBBUkNIX1NSQykKICAgICByZXR1cm4gcGFja2Fn ZV9zb3VyY2U7CkBAIC0xMTIsNiArMTE4LDkgQEAgU29sdmFibGVWZXJzaW9u OjpvYnNvbGV0ZXMoKSBjb25zdAogY29uc3QgUGFja2FnZURlcGVuZHMKIFNv bHZhYmxlVmVyc2lvbjo6ZGVwbGlzdChJZCBrZXluYW1lKSBjb25zdAogewor ICBzdGF0aWMgUGFja2FnZURlcGVuZHMgZW1wdHlfcGFja2FnZTsKKyAgaWYg KCFwb29sKQorICAgIHJldHVybiBlbXB0eV9wYWNrYWdlOwogICBTb2x2YWJs ZSAqc29sdmFibGUgPSBwb29sX2lkMnNvbHZhYmxlKHBvb2wsIGlkKTsKIAog ICBRdWV1ZSBxOwpAQCAtMTQ3LDEzICsxNTYsMTQgQEAgU29sdmFibGVWZXJz aW9uOjpkZXBsaXN0KElkIGtleW5hbWUpIGNvbnN0CiAgICAgfQogCiAgIC8v IG90aGVyd2lzZSwgcmV0dXJuIGFuIGVtcHR5IGRlcGVuZHMgbGlzdAotICBz dGF0aWMgUGFja2FnZURlcGVuZHMgZW1wdHlfcGFja2FnZTsKICAgcmV0dXJu IGVtcHR5X3BhY2thZ2U7CiB9CiAKIGNvbnN0IHN0ZDo6c3RyaW5nCiBTb2x2 YWJsZVZlcnNpb246OlNEZXNjICgpIGNvbnN0CiB7CisgIGlmICghcG9vbCkK KyAgICByZXR1cm4gIiI7CiAgIFNvbHZhYmxlICpzb2x2YWJsZSA9IHBvb2xf aWQyc29sdmFibGUocG9vbCwgaWQpOwogICBjb25zdCBjaGFyICpzZGVzYyA9 IHJlcG9fbG9va3VwX3N0cihzb2x2YWJsZS0+cmVwbywgaWQsIFNPTFZBQkxF X1NVTU1BUlkpOwogICByZXR1cm4gc2Rlc2M7CkBAIC0xOTcsNiArMjA3LDgg QEAgU29sdmFibGVWZXJzaW9uOjpzb3VyY2VQYWNrYWdlICgpIGNvbnN0CiB2 b2lkCiBTb2x2YWJsZVZlcnNpb246OmZpeHVwX3Nwa2dfaWQgKFNvbHZhYmxl VmVyc2lvbiBzcGtnX2lkKSBjb25zdAogeworICBpZiAoIXBvb2wpCisgICAg cmV0dXJuOwogICBTb2x2YWJsZSAqc29sdmFibGUgPSBwb29sX2lkMnNvbHZh YmxlKHBvb2wsIGlkKTsKICAgUmVwb2RhdGEgKmRhdGEgPSByZXBvX2xhc3Rf cmVwb2RhdGEoc29sdmFibGUtPnJlcG8pOwogICBJZCBoYW5kbGUgPSBpZDsK QEAgLTIzNyw2ICsyNDksOCBAQCBTb2x2YWJsZVZlcnNpb246OmFjY2Vzc2li bGUgKCkgY29uc3QKIHBhY2thZ2Vfc3RhYmlsaXR5X3QKIFNvbHZhYmxlVmVy c2lvbjo6U3RhYmlsaXR5ICgpIGNvbnN0CiB7CisgIGlmICghcG9vbCkKKyAg ICByZXR1cm4gVFJVU1RfVU5LTk9XTjsKICAgU29sdmFibGUgKnNvbHZhYmxl ID0gcG9vbF9pZDJzb2x2YWJsZShwb29sLCBpZCk7CiAgIElkIHN0YWJpbGl0 eV9hdHRyID0gcG9vbF9zdHIyaWQocG9vbCwgInNvbHZhYmxlOnN0YWJpbGl0 eSIsIDEpOwogICByZXR1cm4gKHBhY2thZ2Vfc3RhYmlsaXR5X3QpcmVwb19s b29rdXBfbnVtKHNvbHZhYmxlLT5yZXBvLCBpZCwgc3RhYmlsaXR5X2F0dHIs IFRSVVNUX1VOS05PV04pOwotLSAKMi4xNC4yCgo= --------------3732D1967879F1C962D74ADC--