Re: setup crashing - fixed? (TNG)

Re: setup crashing - fixed? (TNG)

[Michael A Chase]

----- Original Message -----
From: "Michael A Chase" <mchase@ix.netcom.com>
To: "Robert Collins" <robert.collins@itdomain.com.au>;
<cygwin-apps@sources.redhat.com>
Sent: Saturday, January 26, 2002 22:49
Subject: Re: setup crashing - fixed?


> ----- Original Message -----
> From: "Robert Collins" <robert.collins@itdomain.com.au>
> To: <cygwin-apps@sources.redhat.com>
> Sent: Saturday, January 26, 2002 22:41
> Subject: setup crashing - fixed?
>
>
> > site (char const *newkey)
> > {
> >   key = new char[strlen (newkey + 1)];
> >                                ^^^^^
> >     strcpy (key, newkey);
> > };
> >
> > However, fixing that DID NOT fix the problem (although I had isolated
> > the fault to this constructor by means of replacement new and new[]
> > calls using HeapAlloc, combined with HeapValidate().)
> >
> > Moving the constructor body out of the header fixed the problem. I don't
> > have time to generate a testcase, but if anyone does have time, I'm sure
> > the gcc team would appreciate knowing about this. The fault occured when
> > that constructor was called from a template instantiation of list.h.
>
> I hope you moved the '+ 1' outside the strlen() as well.


You did.
--
Mac :})
** I normally forward private questions to the appropriate mail list. **
Give a hobbit a fish and he eats fish for a day.
Give a hobbit a ring and he eats fish for an age.