setup.exe /var, /tmp?

setup.exe /var, /tmp?

[Jan Nieuwenhuizen]

Hi,

I've tried a fresh install, using a newly built setup200202 setup.exe,
but it seems that /var and /tmp are not being created any more.

I'm fairly sure that at least /var used to be created by setup.exe
automagically.

Jan.

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music typesetter
http://www.xs4all.nl/~jantien       | http://www.lilypond.org

Re: setup.exe /var, /tmp?

[Robert Collins]

Please try this patch...
Rob

Index: package_meta.cc
===================================================================
RCS file: /cvs/src/src/winsup/cinstall/package_meta.cc,v
retrieving revision 2.17.2.1
diff -u -p -r2.17.2.1 package_meta.cc
--- package_meta.cc 2002/02/19 03:50:23 2.17.2.1
+++ package_meta.cc 2002/02/20 10:23:31
@@ -43,21 +43,21 @@ static const char *cvsid = "\n%%% $Id: p
 #include "package_db.h"

 static const char *standard_dirs[] = {
-  "/bin",
-  "/etc",
-  "/lib",
-  "/tmp",
-  "/usr",
-  "/usr/bin",
-  "/usr/lib",
-  "/usr/src",
-  "/usr/local",
-  "/usr/local/bin",
-  "/usr/local/etc",
-  "/usr/local/lib",
-  "/usr/tmp",
-  "/var/run",
-  "/var/tmp",
+  "bin",
+  "etc",
+  "lib",
+  "tmp",
+  "usr",
+  "usr/bin",
+  "usr/lib",
+  "usr/src",
+  "usr/local",
+  "usr/local/bin",
+  "usr/local/etc",
+  "usr/local/lib",
+  "usr/tmp",
+  "var/run",
+  "var/tmp",
   0
 };



===
----- Original Message -----
From: "Jan Nieuwenhuizen" <janneke@gnu.org>
To: <cygwin-apps@cygwin.com>
Sent: Wednesday, February 20, 2002 10:22 AM
Subject: setup.exe /var, /tmp?


> Hi,
>
> I've tried a fresh install, using a newly built setup200202 setup.exe,
> but it seems that /var and /tmp are not being created any more.
>
> I'm fairly sure that at least /var used to be created by setup.exe
> automagically.
>
> Jan.
>
> --
> Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music
typesetter
> http://www.xs4all.nl/~jantien       | http://www.lilypond.org
>
>

Re: setup.exe /var, /tmp?

[Jan Nieuwenhuizen]

"Robert Collins" <robert.collins@itdomain.com.au> writes:

> Please try this patch...

Hmm, this doesn't help.  Similar fix applied to install.cc also
doesn't help.  After removing c:/cygwin and doing a fresh install, you
get the error message:

    cannot open log file C:/cygwin/var/log/setup.log.full for writing.

(but that's not as bad as that tetex/texmf will fail until /var gets
created :-).

Also, in the select packages dialog, when expanding a category,
packages are often not visible; just empty spaces.  It seems to be
some kind of redraw problem; it works somewhat for categories near the
top of the list, but not for categories below the center; ie, this is
what I see after expanding some categories:

+ All () Default
  + Base () Default
  + Devel () Default
  + Doc () Default
  + Editors () Default
              0-2-1     () Keep  [] ed: The GNU versio|-> rest of line blank
  + Graphics () Default
  + Interpreters () Default


  + Libs () Default
  + Net () Default
  + Publishing () Default

  + Shells () Default

  
  + Text () Default


  
See also
    http://appel.lilypond.org/lilypond/cygwin/setup.jpeg
      
Greetings,
Jan.
  
-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music typesetter
http://www.xs4all.nl/~jantien       | http://www.lilypond.org

Re: setup.exe /var, /tmp?

[Jan Nieuwenhuizen]

"Robert Collins" <robert.collins@itdomain.com.au> writes:

> Install.cc doesn't need that fix. It needs a different one I think - see
> if this helps.

Yes, this helps.  What about /home[/<logname>]?

> As for the graphics problem, I can't reproduce it here,

Ok.  That was on a windows98 box...

Jan.
-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music typesetter
http://www.xs4all.nl/~jantien       | http://www.lilypond.org

Re: setup.exe /var, /tmp?

[Robert Collins]

===
----- Original Message -----
From: "Jan Nieuwenhuizen" <janneke@gnu.org>
> > Please try this patch...
>
> Hmm, this doesn't help.  Similar fix applied to install.cc also
> doesn't help.  After removing c:/cygwin and doing a fresh install, you
> get the error message:
>
>     cannot open log file C:/cygwin/var/log/setup.log.full for writing.

Install.cc doesn't need that fix. It needs a different one I think - see
if this helps.

As for the graphics problem, I can't reproduce it here,
Rob

Index: install.cc
===================================================================
RCS file: /cvs/src/src/winsup/cinstall/install.cc,v
retrieving revision 2.41.2.1
diff -u -p -r2.41.2.1 install.cc
--- install.cc 2002/02/19 02:47:59 2.41.2.1
+++ install.cc 2002/02/20 21:29:52
@@ -426,13 +426,13 @@ do_install_thread (HINSTANCE h, HWND own

   next_dialog = IDD_DESKTOP;

-  io_stream::mkpath_p (PATH_TO_DIR, get_root_dir ());
+  io_stream::mkpath_p (PATH_TO_DIR, String ("file://") + get_root_dir
());

   for (i = 0; standard_dirs[i]; i++)
     {
       String p = cygpath (standard_dirs[i]);
       if (p.size())
- io_stream::mkpath_p (PATH_TO_DIR, p);
+ io_stream::mkpath_p (PATH_TO_DIR, String ("file://") + p);
     }

   /* Create /var/run/utmp */
Index: log.cc
===================================================================
RCS file: /cvs/src/src/winsup/cinstall/log.cc,v
retrieving revision 2.9.2.1
diff -u -p -r2.9.2.1 log.cc
--- log.cc 2002/02/19 00:43:14 2.9.2.1
+++ log.cc 2002/02/20 21:29:52
@@ -88,7 +88,7 @@ log_save (int babble, String const &file
     return;
   been_here = 1;

-  io_stream::mkpath_p (PATH_TO_FILE, filename);
+  io_stream::mkpath_p (PATH_TO_FILE, String("file://")+filename);

   io_stream *f = io_stream::open(String("file://")+filename, append ?
"at" : "wt");
   if (!f)
Index: package_meta.cc
===================================================================
RCS file: /cvs/src/src/winsup/cinstall/package_meta.cc,v
retrieving revision 2.17.2.1
diff -u -p -r2.17.2.1 package_meta.cc
--- package_meta.cc 2002/02/19 03:50:23 2.17.2.1
+++ package_meta.cc 2002/02/20 21:29:52
@@ -43,21 +43,21 @@ static const char *cvsid = "\n%%% $Id: p
 #include "package_db.h"

 static const char *standard_dirs[] = {
-  "/bin",
-  "/etc",
-  "/lib",
-  "/tmp",
-  "/usr",
-  "/usr/bin",
-  "/usr/lib",
-  "/usr/src",
-  "/usr/local",
-  "/usr/local/bin",
-  "/usr/local/etc",
-  "/usr/local/lib",
-  "/usr/tmp",
-  "/var/run",
-  "/var/tmp",
+  "bin",
+  "etc",
+  "lib",
+  "tmp",
+  "usr",
+  "usr/bin",
+  "usr/lib",
+  "usr/src",
+  "usr/local",
+  "usr/local/bin",
+  "usr/local/etc",
+  "usr/local/lib",
+  "usr/tmp",
+  "var/run",
+  "var/tmp",
   0
 };

Re: setup.exe /var, /tmp?

[Michael A Chase]

----- Original Message -----
From: "Robert Collins" <robert.collins@itdomain.com.au>
To: "Jan Nieuwenhuizen" <janneke@gnu.org>
Cc: <cygwin-apps@cygwin.com>
Sent: Wednesday, February 20, 2002 13:31
Subject: Re: setup.exe /var, /tmp?


>
> ===
> ----- Original Message -----
> From: "Jan Nieuwenhuizen" <janneke@gnu.org>
> > > Please try this patch...
> >
> > Hmm, this doesn't help.  Similar fix applied to install.cc also
> > doesn't help.  After removing c:/cygwin and doing a fresh install, you
> > get the error message:
> >
> >     cannot open log file C:/cygwin/var/log/setup.log.full for writing.
>
> Install.cc doesn't need that fix. It needs a different one I think - see
> if this helps.

These are probably not the only places where the prefixes may be missing.
Would it be worthwhile to add a log() call if no "file://" or "cygfile://"
prefix is found in io_stream::mkpath_p()?

I'm doing a search for all the mkpath_p() calls I can find, but often the
file or directory name is passed from somewhere else.
--
Mac :})
** I normally forward private questions to the appropriate mail list. **
Ask Smarter: http://www.tuxedo.org/~esr/faqs/smart-questions.html
Give a hobbit a fish and he eats fish for a day.
Give a hobbit a ring and he eats fish for an age.

Re: setup.exe /var, /tmp?

[Robert Collins]

===
----- Original Message -----
From: "Michael A Chase" <mchase@ix.netcom.com>

> These are probably not the only places where the prefixes may be
missing.
> Would it be worthwhile to add a log() call if no "file://" or
"cygfile://"
> prefix is found in io_stream::mkpath_p()?

Possibly in your sandbox. I don't feel the need in CVS though :}.

> I'm doing a search for all the mkpath_p() calls I can find, but often
the
> file or directory name is passed from somewhere else.

Thank you.

Rob

Re: setup.exe /var, /tmp?

[Robert Collins]

Jan,
    is this fully sorted with the last patch I sent you?

Rob
===
----- Original Message -----
From: "Jan Nieuwenhuizen" <janneke@gnu.org>
To: <cygwin-apps@cygwin.com>
Sent: Wednesday, February 20, 2002 10:22 AM
Subject: setup.exe /var, /tmp?


> Hi,
>
> I've tried a fresh install, using a newly built setup200202 setup.exe,
> but it seems that /var and /tmp are not being created any more.
>
> I'm fairly sure that at least /var used to be created by setup.exe
> automagically.
>
> Jan.
>
> --
> Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music
typesetter
> http://www.xs4all.nl/~jantien       | http://www.lilypond.org
>
>

Re: setup.exe /var, /tmp?

[Jan Nieuwenhuizen]

"Robert Collins" <robert.collins@itdomain.com.au> writes:

> Jan,
>     is this fully sorted with the last patch I sent you?

Yes, that second file:// patch was fine.

Greetings,
Jan.

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music typesetter
http://www.xs4all.nl/~jantien       | http://www.lilypond.org

Re: setup.exe /var, /tmp?

[Robert Collins]

===
----- Original Message -----
From: "Jan Nieuwenhuizen" <janneke@gnu.org>
To: "Robert Collins" <robert.collins@itdomain.com.au>
Cc: <cygwin-apps@cygwin.com>
Sent: Monday, February 25, 2002 3:03 AM
Subject: Re: setup.exe /var, /tmp?


> "Robert Collins" <robert.collins@itdomain.com.au> writes:
>
> > Jan,
> >     is this fully sorted with the last patch I sent you?
>
> Yes, that second file:// patch was fine.

Thanks!

Ok, I now know of no release-blocking bugs in setup200202. Shall we have
a open beta again?

Rob