From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail2.pdinc.us (mail2.pdinc.us [67.90.184.28]) by sourceware.org (Postfix) with ESMTPS id CDD2E3938C02 for ; Tue, 18 May 2021 19:17:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CDD2E3938C02 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=pdinc.us Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jpyeron@pdinc.us Received: from lovegrove (nsa1.pdinc.us [67.90.184.2]) (authenticated bits=0) by mail2.pdinc.us (8.14.4/8.14.4) with ESMTP id 14IJHh41017103 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Tue, 18 May 2021 15:17:43 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 mail2.pdinc.us 14IJHh41017103 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pdinc.us; s=default; t=1621365463; bh=p8IFOt5K7ohL55RCDt1Evqf9/7dsT5gdYrc/cafSR+8=; h=From:To:References:In-Reply-To:Subject:Date:From; b=dZ1pyI4Go+dMDDZtqS1oXY+zoBjlR6ovkUt5SwHKV3yAdfMEnyumDugcIypCspwuV xNtkfNbTMmNzUnXXP/RVQN24yLycriQFd/tkaff2mdG8Yqiq2NyfcJpsezgQbmPfzZ 7eVgLNK6blpp9gU05QEDGJ49w4lTL3mG8pBRN81vhmIFbx89WyoghHLmrf5yFl8ydk fC5xJwH6Y1yyHOGSeQBeflrFz/dlNxh8Cuw7XGhlhORlKkQCJQyzZ267gLePlvjs+M 7BKbwETT3PZkUTm1fdxqPSW6vWihCCSHEDE5ezVZN8rAzlxoewuaukPJy3Nlk766XZ Lmg2pJ4UtClOw== From: "Jason Pyeron" To: References: <01ad01d74517$f9f4e6e0$eddeb4a0$@pdinc.us> <87h7jbuqir.fsf@Otto.invalid> <009c01d74b6c$1ce8f7e0$56bae7a0$@pdinc.us> <8735ukejz2.fsf@Otto.invalid> In-Reply-To: <8735ukejz2.fsf@Otto.invalid> Subject: RE: cygport test has zero exit status on failures Date: Tue, 18 May 2021 15:17:53 -0400 Message-ID: <03dc01d74c1a$80c3df60$824b9e20$@pdinc.us> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQJBbTc15Bo1skbt1oV0TZ9pIm0uHQIt0WKZAlT4aq8BajoWSanl8T8A Content-Language: en-us X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_INFOUSMEBIZ, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 May 2021 19:17:47 -0000 > -----Original Message----- > From: ASSI > Sent: Tuesday, May 18, 2021 12:37 AM >=20 > Jason Pyeron writes: > > What is the historic rationale behind the "OR true" after the make > > check? >=20 > Not historic for the most part, I'd say. Cygport can also do > cross-builds of packages and in those cases the tests will seldomly = work > (at all or at least partly) unless upstream walked the extra mile. > Also, due to ATWIL syndrome and other factors, Cygwin is often not Which is why I want the tests to fail - so it causes patches to be = created... and pushed upstream. > explicitly considered a target platform or (even then) treated wrongly > in different ways, so even when building natively you will encounter > your fair share of spurious test fails. >=20 > > It seems silly to have to redefine src_test() as { > > cd ${B} > > make check > > }, just to have a failure exit code if the test fail. >=20 > It would be equally silly the other way around in a different set of > circumstances. But yes, making this configurable might be useful, but > this should then be done in the local configuration, not in the = cygport > file. If I put it in ~/.config/cygport.conf it will impact all packages, not = just the "one". The only place it is limited to applicable package is in = the package.cygport file, or am I missing something? e.g. $ cat pdfgrep.cygport NAME=3D"pdfgrep" VERSION=3D2.1.2 RELEASE=3D1 CATEGORY=3D"Text" SUMMARY=3D"Command-line utility for searching text in PDFs" DESCRIPTION=3D"Pdfgrep is a tool to search text in PDF files. It works = much like grep, with one distinction: it operates on pages and not on lines." HOMEPAGE=3D"https://pdfgrep.org/" SRC_URI=3D"https://pdfgrep.org/download/pdfgrep-${VERSION}.tar.gz" # git format-patch --stdout v2.1.2..cygwin-2.1.2 > = v2.1.2..cygwin-2.1.2.patch PATCH_URI=3D"v2.1.2..cygwin-2.1.2.patch" BUILD_REQUIRES=3D"asciidoc gcc-g++ libpoppler-cpp-devel libgcrypt-devel = libpcre-devel dejagnu texlive-collection-latex" src_test() { cd ${B} make check }