public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
* enhancement to cygport 34?
@ 2021-09-22 18:02 Jason Pyeron
  0 siblings, 0 replies; only message in thread
From: Jason Pyeron @ 2021-09-22 18:02 UTC (permalink / raw)
  To: cygwin-apps

Would this be an acceptable improvement?

I would like my cygport file to capture specific and deviant requirements. E.g. cannot compile with GCC 10+

The warning emitted is better than relying on a commit message or comment in the cygport.

$ diff -u usr/share/cygport/lib/check_funcs.cygpart.orig usr/share/cygport/lib/check_funcs.cygpart
--- usr/share/cygport/lib/check_funcs.cygpart.orig  2021-09-22 13:35:56.487943200 -0400
+++ usr/share/cygport/lib/check_funcs.cygpart       2021-09-22 13:46:23.336143300 -0400
@@ -634,7 +634,7 @@
                        # package checks not available on other systems
                        if check_prog cygcheck
                        then
-                               cygcheck -cd ${atom} | dos2unix | grep -q "^${atom} " || failed_atoms+="${atom} "
+                               cygcheck -cd ${atom//=*/} | dos2unix | grep -Eq "^${atom//=/ +}( |$)" || failed_atoms+="${atom//=*/} "
                        fi
                        ;;
                esac



This would allow a BUILD_REQUIRES='gcc-core=9.3.0-2' or 'gcc-core=9\..*'

I choose = because it was never used in a version number for all the setup.ini I have cached on my system and it feels natural.

-Jason

--
Jason Pyeron  | Architect
PD Inc        | Certified SBA 8(a)
10 w 24th St  | Certified SBA HUBZone
Baltimore, MD | CAGE Code: 1WVR6

.mil: jason.j.pyeron.ctr@mail.mil
.com: jpyeron@pdinc.us
tel : 202-741-9397




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-09-22 18:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-22 18:02 enhancement to cygport 34? Jason Pyeron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).