From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7254 invoked by alias); 8 Dec 2017 15:48:35 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 2570 invoked by uid 89); 8 Dec 2017 15:48:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy= X-HELO: out3-smtp.messagingengine.com Received: from out3-smtp.messagingengine.com (HELO out3-smtp.messagingengine.com) (66.111.4.27) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Dec 2017 15:48:20 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B82A820C0A for ; Fri, 8 Dec 2017 10:48:16 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Fri, 08 Dec 2017 10:48:16 -0500 X-ME-Sender: Received: from [192.168.1.102] (host86-179-113-49.range86-179.btcentralplus.com [86.179.113.49]) by mail.messagingengine.com (Postfix) with ESMTPA id 531E6248BA for ; Fri, 8 Dec 2017 10:48:16 -0500 (EST) Subject: Re: [PATCH setup] Make Enter in the user URL box cause ADD instead of NEXT To: cygwin-apps@cygwin.com References: <20171204155855.9484-1-kbrown@cornell.edu> <99be290c-6134-9bb9-6231-b0635a1e3fe9@cornell.edu> <5695aabd-2952-3ce7-9a5d-bd47afd4f849@cornell.edu> <395035be-4ef6-fbb4-4644-5a4b21f3b3ea@dronecode.org.uk> From: Jon Turney Message-ID: <08c463e1-348d-0c9c-fea5-34b0f42f8dd7@dronecode.org.uk> Date: Fri, 08 Dec 2017 15:48:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------21696AF2DD34B671286E94DC" X-SW-Source: 2017-12/txt/msg00047.txt.bz2 This is a multi-part message in MIME format. --------------21696AF2DD34B671286E94DC Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-length: 1970 On 07/12/2017 20:46, Ken Brown wrote: > On 12/7/2017 1:35 PM, Jon Turney wrote: >> On 05/12/2017 17:32, Ken Brown wrote: >>> On 12/5/2017 11:03 AM, Ken Brown wrote: >>>> On 12/5/2017 7:58 AM, Jon Turney wrote: >>>>> The search textbox on the package chooser page needs the same fix. >>>> >>>> It's not immediately clear to me how to do this, since I don't know >>>> what the default pushbutton should be while the user is typing in >>>> the search box. >>>> >>>> One possibility is to convert the label "Search" to the left of the >>>> box to a SEARCH pushbutton, whose effect is to call >>>> OnTimerMessage(). If we make this the default, then pressing Enter >>>> will cause the search filter to immediately take effect, which is >>>> probably what the user expects. >> >> It seems a bit weird to have a button which automatically pushes >> itself half a second after you finish typing. >> >> Attached is my attempt, which (ab)uses an invisible button. > > I agree, this is better than my version. > >>> Something like the attached?  This might not be quite right, because >>> the previous default button is never restored.  I'm not sure how >>> important that is. >> >> I think it's something that should be done, if possible, so I added that. > > In my testing, 'Next' does indeed become the default button after I > click outside of the textbox, but there's no visual indication of this. This is interesting: if you use TAB to move the focus out of the textbox, then first "Clear" gets highlight (because it's a pushbutton and enter pushes it), TAB again and "Current is selected (but "Next" gets the highlight, because that's what enter pushes) If you click to move the focus, it only seems to update the highlight the second time you do that. Which I guess suggests we should be ensuring the highlight is drawn on EN_KILLFOCUS? But once I do that, it seems I need to explicitly remove as well, which gives the attached, incremental patch. --------------21696AF2DD34B671286E94DC Content-Type: text/plain; charset=UTF-8; name="0001-Explicitly-remove-defpushbutton-style-from-Next-butt.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Explicitly-remove-defpushbutton-style-from-Next-butt.pa"; filename*1="tch" Content-length: 1952 RnJvbSA0MzA4YzQ0OGQzM2U1ZGU5OTM1ODZhNDU3M2Y2ODEwZWZkZDI2YmJm IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gVHVybmV5IDxq b24udHVybmV5QGRyb25lY29kZS5vcmcudWs+CkRhdGU6IEZyaSwgOCBEZWMg MjAxNyAxNTo0NDowMyArMDAwMApTdWJqZWN0OiBbUEFUQ0ggc2V0dXBdIEV4 cGxpY2l0bHkgcmVtb3ZlIGRlZnB1c2hidXR0b24gc3R5bGUgZnJvbSAiTmV4 dCIKIGJ1dHRvbiB3aGVuIG5vdCBkZWZhdWx0CgotLS0KIGNob29zZS5jYyB8 IDEwICsrKysrKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMo KyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvY2hvb3NlLmNjIGIv Y2hvb3NlLmNjCmluZGV4IDQyMTlhODEuLmQ3MjY1Y2IgMTAwNjQ0Ci0tLSBh L2Nob29zZS5jYworKysgYi9jaG9vc2UuY2MKQEAgLTI3LDYgKzI3LDcgQEAK ICAgIGRlZmF1bHQuICovCiAKICNpbmNsdWRlICJ3aW4zMi5oIgorI2luY2x1 ZGUgIndpbmRvd3N4LmgiCiAjaW5jbHVkZSA8Y29tbWN0cmwuaD4KICNpbmNs dWRlIDxzdGRpby5oPgogI2luY2x1ZGUgPHN0ZGxpYi5oPgpAQCAtMzg2LDE0 ICszODcsMTkgQEAgQ2hvb3NlclBhZ2U6Ok9uTWVzc2FnZUNtZCAoaW50IGlk LCBIV05EIGh3bmRjdGwsIFVJTlQgY29kZSkKIAogICBpZiAoaWQgPT0gSURD X0NIT09TRV9TRUFSQ0hfRURJVCkKICAgICB7CisgICAgICBIV05EIG5leHRC dXR0b24gPSA6OkdldERsZ0l0ZW0oOjpHZXRQYXJlbnQoR2V0SFdORCgpKSwg MHgzMDI0IC8qIElEX1dJWk5FWFQgKi8pOworCiAgICAgICBpZiAoY29kZSA9 PSBFTl9DSEFOR0UpCiAgICAgICAgIHsKICAgICAgICAgICBTZW5kTWVzc2Fn ZSAoR2V0SFdORCAoKSwgRE1fU0VUREVGSUQsIChXUEFSQU0pIElEQ19DSE9P U0VfRE9fU0VBUkNILCAwKTsKKyAgICAgICAgICBCdXR0b25fU2V0U3R5bGUo bmV4dEJ1dHRvbiwgQlNfUFVTSEJVVFRPTiwgVFJVRSk7CiAgICAgICAgICAg U2V0VGltZXIoR2V0SFdORCAoKSwgdGltZXJfaWQsIFNFQVJDSF9USU1FUl9E RUxBWSwgKFRJTUVSUFJPQykgTlVMTCk7CiAgICAgICAgIH0KICAgICAgIGVs c2UgaWYgKGNvZGUgPT0gRU5fS0lMTEZPQ1VTKQotICAgICAgICBTZW5kTWVz c2FnZSAoR2V0SFdORCAoKSwgRE1fU0VUREVGSUQsIChXUEFSQU0pIDB4MzAy NCAvKiBJRF9XSVpORVhUICovLCAwKTsKLQorICAgICAgICB7CisgICAgICAg ICAgU2VuZE1lc3NhZ2UgKEdldEhXTkQgKCksIERNX1NFVERFRklELCAoV1BB UkFNKSAweDMwMjQgLyogSURfV0laTkVYVCAqLywgMCk7CisgICAgICAgICAg QnV0dG9uX1NldFN0eWxlKG5leHRCdXR0b24sIEJTX0RFRlBVU0hCVVRUT04s IFRSVUUpOworICAgICAgICB9CiAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9 CiAgIGVsc2UgaWYgKGNvZGUgPT0gQk5fQ0xJQ0tFRCkKLS0gCjIuMTUuMQoK --------------21696AF2DD34B671286E94DC--