From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-045.btinternet.com (mailomta7-sa.btinternet.com [213.120.69.13]) by sourceware.org (Postfix) with ESMTPS id D6B453858412 for ; Thu, 16 Feb 2023 18:48:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D6B453858412 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from sa-prd-rgout-004.btmx-prd.synchronoss.net ([10.2.38.7]) by sa-prd-fep-045.btinternet.com with ESMTP id <20230216184825.HVZB5235.sa-prd-fep-045.btinternet.com@sa-prd-rgout-004.btmx-prd.synchronoss.net>; Thu, 16 Feb 2023 18:48:25 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 613943C64FEC6B23 X-Originating-IP: [81.153.98.246] X-OWM-Source-IP: 81.153.98.246 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvhedrudeijedgudduhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhepgeegudeltefgffeihefffeegjedvkeeiteehueetleehudelvdevleegjefhffejnecuffhomhgrihhnpegurghpvghrrdhnvghtnecukfhppeekuddrudehfedrleekrddvgeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdeingdpihhnvghtpeekuddrudehfedrleekrddvgeeipdhmrghilhhfrhhomhepjhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhdpnhgspghrtghpthhtohepvddprhgtphhtthhopegthihgfihinhdqrghpphhssegthihgfihinhdrtghomhdprhgtphhtthhopehtrghkrghshhhirdihrghnohesnhhifhhthidrnhgvrdhjph X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.153.98.246) by sa-prd-rgout-004.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 613943C64FEC6B23; Thu, 16 Feb 2023 18:48:25 +0000 Message-ID: <0932aaa8-f4ce-f2a4-8da7-8c486cdaec14@dronecode.org.uk> Date: Thu, 16 Feb 2023 18:48:24 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [ITP] moc (2.6.r3005) Content-Language: en-GB To: Takashi Yano , "cygwin-apps@cygwin.com" References: <20230120193603.3a1a8003e73957cf505ce391@nifty.ne.jp> <20230206225821.de89a0449061c17e041a20a2@nifty.ne.jp> <20230209215418.0547560ecd3921956bc3394d@nifty.ne.jp> <56a413ca-d36f-3390-e592-096322ec3f79@dronecode.org.uk> <20230214181110.e0be6c4b43bdff087751959b@nifty.ne.jp> From: Jon Turney In-Reply-To: <20230214181110.e0be6c4b43bdff087751959b@nifty.ne.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1191.5 required=5.0 tests=BAYES_00,FORGED_SPF_HELO,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14/02/2023 09:11, Takashi Yano via Cygwin-apps wrote: > On Mon, 13 Feb 2023 18:25:43 +0000 > Jon Turney wrote: >> On 09/02/2023 12:54, Takashi Yano via Cygwin-apps wrote: >>> NAME="moc" >>> VERSION=2.6.r3005 >>> RELEASE=1 >> [...] >>> SVN_URI="svn://svn.daper.net/moc/trunk" >>> SVN_REV="3005" >>> inherit svn >> >> You could (and probably should) write this as >> >> SVN_REV=${VERSION##*.r} >> >> so you don't have to remember to update it in both places. >> >> (See 'Remove matching prefix pattern' in the section 'Parameter >> Expansion' in 'man bash') >> >> >> Otherwise, looks good. > > Thanks. I revised the cygport file. Approved.