From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-h1p-028592.sys.comcast.net (resqmta-h1p-028592.sys.comcast.net [IPv6:2001:558:fd02:2446::5]) by sourceware.org (Postfix) with ESMTPS id 9874E3858D37 for ; Thu, 6 Oct 2022 18:21:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9874E3858D37 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=acm.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=acm.org Received: from resomta-h1p-027912.sys.comcast.net ([96.102.179.201]) by resqmta-h1p-028592.sys.comcast.net with ESMTP id gRJ8ooOZ6Sl18gVURogyLH; Thu, 06 Oct 2022 18:20:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcastmailservice.net; s=20211018a; t=1665080459; bh=Rm1AOfOCSKyQKiY7a/AWN7tfQpZSuk0B/zS7RMQ1084=; h=Received:Received:Message-ID:Date:MIME-Version:Subject:To:From: Content-Type; b=FTcpKy+hyC1DJN/6nTeO2nCAuQKPe7COBaGoB8/Aq3gp54jfnPjEWk+Cn9H683nDl eSKebnjBb1kTkgedevxpdPaWsxAMiDaQD4a4GAK/EaX9a8sj+4og28Z51eBbPkAxWE w6aqdz7U80yMHl9CbUkHCsSN2893lqlCzp6WRnLCTJl25q3+sjlBQfwZNwypjf2TPR VfQRsAoHSN7fgHuDFfP1cN41lQNzBrIiRqYb6mo/oVTKK5gG66e16DbQBZHkJIoGbg 9H5iC2Ifivgykkf0zR/jehZai0FrvqNyFfQTURjiTIYD/Tgvq/5/uLfEoaEbY8aUEV k8fbgFe9M6pVg== Received: from [IPV6:2601:547:c500:dbe:5dc8:bd35:1bab:eaed] ([IPv6:2601:547:c500:dbe:5dc8:bd35:1bab:eaed]) by resomta-h1p-027912.sys.comcast.net with ESMTPSA id gVU3oSbBDX0tdgVU4owIuU; Thu, 06 Oct 2022 18:20:37 +0000 X-Xfinity-VMeta: sc=0.00;st=legit Message-ID: <0a7633f3-f5ed-b436-6b5f-d7adbf9d37ba@acm.org> Date: Thu, 6 Oct 2022 14:20:34 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [ITP] rsync 3.2.6 Content-Language: en-US To: "cygwin-apps@cygwin.com" References: <9fbe1bb3-8da9-0b5d-e695-6f9b24a8b8ee@acm.org> <20221006172431.x74omlu2as5m2lcz@lucy.dinwoodie.org> From: Chad Dougherty In-Reply-To: <20221006172431.x74omlu2as5m2lcz@lucy.dinwoodie.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_DMARC_NONE,KAM_NUMSUBJECT,NICE_REPLY_A,SPF_HELO_PASS,SPF_SOFTFAIL,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-10-06 13:24, Adam Dinwoodie wrote: > "no iconv" concerns me; I'm not desperately familiar with how iconv > works, but I believe that'll potentially cause issues for rsync users > who aren't using ASCII. I'd guess the issue is your build environment > is missing a relevant build-time dependency, probably libiconv or > libiconv-devel. > Yeah, come to think of it that one also stuck out to me after I sent the mail. I've updated my cygport and associated artifacts to include those dependencies: https://github.com/crd477/cygports/tree/main/rsync Here's an update diff of the features and capabilities, reformatted and sorted for easier comparison: crd@x13:~/src/cygports/rsync$ diff -b old.txt new.txt 1,2c1,2 < rsync version 3.2.4dev protocol version 31 < Copyright (C) 1996-2020 by Andrew Tridgell, Wayne Davison, and others. --- > rsync version 3.2.6 protocol version 31 > Copyright (C) 1996-2022 by Andrew Tridgell, Wayne Davison, and others. 13a14,15 > crtimes > hardlink-symlinks 17d18 < no crtimes 19c20 < optional protect-args --- > optional secluded-args 27,28c28,30 < no SIMD < asm --- > no SIMD-roll > no asm-MD5 > no asm-roll I think the diffs after "19c20" above should be safe to ignore as the release notes explain them: " - Renamed configure's `--enable-simd` option to `--enable-roll-simd` and added the option `--enable-roll-asm` to use the new asm version of the code. Both are x86_64/amd64 only. - Renamed configure's `--enable-asm` option to `--enable-md5-asm` to avoid confusion with the asm option for the rolling checksum. It is also honored even when openssl crypto is in use. This allows: normal MD4 & MD5, normal MD4 + asm MD5, openssl MD4 & MD5, or openssl MD4 + asm MD5 depending on the configure options selected. - Made SIMD & asm configure checks default to "no" on non-Linux hosts due to various reports of problems on NetBSD & macOS hosts. These were also tweaked to allow enabling the feature on a host_cpu of amd64 (was only allowed on x86_64 before)." Thanks... -- -Chad