From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75924 invoked by alias); 2 May 2017 07:28:44 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 75912 invoked by uid 89); 2 May 2017 07:28:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1060 X-HELO: mail-lf0-f50.google.com Received: from mail-lf0-f50.google.com (HELO mail-lf0-f50.google.com) (209.85.215.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 May 2017 07:28:37 +0000 Received: by mail-lf0-f50.google.com with SMTP id 75so70402746lfs.2 for ; Tue, 02 May 2017 00:28:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=iy3SGMPxuI+TWl8tNsViCBtI/5E0zkxCt3CnTHy7ZOw=; b=IBeihMsnyW4D7cEAyj4ygtvX36IE86ezDJZd5+i+kgMJzvhA8y0EfBXx6wLHuy136t saUW7d84ExMNT7bEHqb+uoNn5XFUocYhjpDRKBQuLHHk+8w/swHpHmQ1wQcVmNA8FDLn JSHY8bNis6Htb+Ty5df7sdeU6PC3e1dGGz0yMsW3zo4HxRb8doQ7DjYdTb+VJAzSET0n RBGoznGLvwcvgPLl5i5xe1xQSqUImc4rEvWZXM59N8Q++HDOzNds0d9vx4KP8uyvyJhe DFc2NGpsxBCwg4mbquD8Ygaoq1YHVq7I9asOqLthDJ1KMEIauDohpfgSQYRjZzamX/yz vD0w== X-Gm-Message-State: AN3rC/53PgXQWl2mOAF9fnPkNFoIcFDlBjolCfWzEnJtA/Vk2GBtvO/L rY86IHZhScv3SQ== X-Received: by 10.25.87.82 with SMTP id l79mr9707437lfb.106.1493710118085; Tue, 02 May 2017 00:28:38 -0700 (PDT) Received: from [192.168.1.117] (tb213-185-244-58.cust.teknikbyran.com. [213.185.244.58]) by smtp.googlemail.com with ESMTPSA id p23sm3041672lfj.35.2017.05.02.00.28.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 May 2017 00:28:37 -0700 (PDT) Subject: Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY) To: Jon Turney , cygwin-apps@cygwin.com References: <20170428121205.12240-1-jon.turney@dronecode.org.uk> <20170428121205.12240-12-jon.turney@dronecode.org.uk> <3d79b33e-e067-c1df-9b90-084fb10dd272@dronecode.org.uk> <9452ab7f-986c-2394-8c24-6208e042787e@dronecode.org.uk> <506da115-b976-fdb2-bf1b-cec6addfbbbb@dronecode.org.uk> From: =?UTF-8?Q?=c3=85ke_Rehnman?= Message-ID: <0b6ab083-d470-c940-5557-d33be5c523cb@gmail.com> Date: Tue, 02 May 2017 07:28:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <506da115-b976-fdb2-bf1b-cec6addfbbbb@dronecode.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00008.txt.bz2 Hello all, On 2017-05-01 22:45, Jon Turney wrote: > It seems this could be an existing bug which could have been triggered > the proxy case. > > The attached incremental patch fixed this for me. Seem to work fine for https and ftp now, I don't have the means to test ftps yet. One thought though, why not let wininet take care of file:// URL's as well? Or actually don't try to parse the url string at all and just pass it down to NETIO_IE5 unfiltered? The advantage is setup would be able to handle what ever protocols wininet has. Also letting wininet taking care of file:// url's would let the user install from a local network resource (i.e file server). I'm been thinking of the case when someone wants to use a local directory repo would be slightly more complicated since relative paths does not work with file url's. One way to solve this particular case would be to check the first character for '.' and use that as an indicator to a local dir. /Ake