public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Federico Kircheis <federico.kircheis@gmail.com>
To: cygwin-apps@cygwin.com
Subject: Re: cygport development
Date: Mon, 14 Oct 2019 08:55:00 -0000	[thread overview]
Message-ID: <0d57d59b-638f-47ae-bdd0-eefda2e63f0c@gmail.com> (raw)
In-Reply-To: <871rvgwqbc.fsf@Rainer.invalid>

On 13/10/2019 18.41, Achim Gratz wrote:
> Federico Kircheis writes:
>> I've sent the patches the 14.07.19, unfortunately I still got no answer.
> 
> The cygport maintainer is rather busy with non-Cygwin related work these
> days, I suppose.  Anyway, one of the questions I have is why you need
> these changes.  Most build systems do not actually work when they
> encounter a path with spaces if they use make under the hood, so fixing
> cygport to grok such path locations isn't getting you much further I'd
> think.  Can you explain?

Yep.

I've built some software in my windows home directory.
It contains a space.
I expected it to work.

Instead of failing with a clear error message, the build process deleted 
some unrelated files as it cd failed (or cd in the wrong directory, cant 
remember right now).

I believe it is unacceptable to delete unrelated data.

Even if it stated that there is no intention to support path with 
spaces, those scripts should fail fast and ideally with a clear error 
message.

I found it easier to quote the offending variables, as not only spaces 
might cause issues.

  reply	other threads:[~2019-10-14  8:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-14 13:25 Federico Kircheis
2019-07-14 17:11 ` Brian Inglis
2019-07-14 19:39   ` [PATCH 1/2] Add support for path with spaces Federico Kircheis
2019-07-14 19:39     ` [PATCH 2/2] Exit in case `cd` fails Federico Kircheis
2019-09-28 11:56   ` cygport development Federico Kircheis
2019-10-13 16:41     ` Achim Gratz
2019-10-14  8:55       ` Federico Kircheis [this message]
2019-10-14 17:15         ` Doug Henderson
2020-05-12 14:59         ` Federico Kircheis
2020-05-15  4:55           ` Yaakov Selkowitz
2020-05-17 17:54             ` Federico Kircheis
2020-05-29  4:38               ` Federico Kircheis
2020-06-12  7:55                 ` Federico Kircheis
2020-06-29 16:04                   ` Federico Kircheis
2021-11-06 14:53                     ` Federico Kircheis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d57d59b-638f-47ae-bdd0-eefda2e63f0c@gmail.com \
    --to=federico.kircheis@gmail.com \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).