From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16637 invoked by alias); 19 Jan 2018 14:18:16 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 16623 invoked by uid 89); 19 Jan 2018 14:18:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=H*Ad:D*hu, Hx-spam-relays-external:ESMTPA X-HELO: out1-smtp.messagingengine.com Received: from out1-smtp.messagingengine.com (HELO out1-smtp.messagingengine.com) (66.111.4.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Jan 2018 14:18:14 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 56F16208A7; Fri, 19 Jan 2018 09:18:13 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Fri, 19 Jan 2018 09:18:13 -0500 X-ME-Sender: Received: from [192.168.1.102] (host86-166-190-81.range86-166.btcentralplus.com [86.166.190.81]) by mail.messagingengine.com (Postfix) with ESMTPA id C66952449D; Fri, 19 Jan 2018 09:18:12 -0500 (EST) Subject: Re: [PATCH setup] Send User-Agent even when setup-specific proxy is used To: cygwin-apps@cygwin.com References: <20180118191654.GB4212@MAY> From: Jon Turney Cc: SZAVAI Gyula Message-ID: <0dd4274b-fd3a-2857-bdb5-087243444407@dronecode.org.uk> Date: Fri, 19 Jan 2018 14:18:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180118191654.GB4212@MAY> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-01/txt/msg00060.txt.bz2 On 18/01/2018 19:16, SZAVAI Gyula wrote: > Setup is sending User-Agent header if direct connection or system proxy > is used, but not when direct(legacy) or setup-specific proxy. Fix this. Thanks for the patch. This is fine, as far as it goes. However, I don't think 'direct(legacy)' is actually doing anything useful these days, so I'd kind of like to remove it (and all the hand-built protocol handling underneath it), and instead teach NetIO_IE5 how to handle a setup-specific proxy configuration as well.