From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124024 invoked by alias); 5 Jul 2017 18:35:59 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 124009 invoked by uid 89); 5 Jul 2017 18:35:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-22.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,UNSUBSCRIBE_BODY autolearn=ham version=3.3.2 spammy=un, appdata, Frequently, Asked X-HELO: smtp-out-no.shaw.ca Received: from smtp-out-no.shaw.ca (HELO smtp-out-no.shaw.ca) (64.59.134.12) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Jul 2017 18:35:55 +0000 Received: from [192.168.1.100] ([24.64.240.204]) by shaw.ca with SMTP id Sp9UdjhkQdTIDSp9VdY2z2; Wed, 05 Jul 2017 12:35:54 -0600 X-Authority-Analysis: v=2.2 cv=UaohcOaN c=1 sm=1 tr=0 a=MVEHjbUiAHxQW0jfcDq5EA==:117 a=MVEHjbUiAHxQW0jfcDq5EA==:17 a=r77TgQKjGQsHNAKrUKIA:9 a=fw6bbcGBmi20T8zm63gA:9 a=QEXdDO2ut3YA:10 a=w_pzkKWiAAAA:8 a=viK-MEzmKuFEQut6kBAA:9 a=CdiWusdWvyIA:10 a=sRI3_1zDfAgwuvI8zelB:22 Reply-To: Brian.Inglis@SystematicSw.ab.ca Subject: Re: setup complains about cygwin-doc package update To: cygwin-apps@cygwin.com References: <20170705142723.GH30902@calimero.vinschen.de> <20170705172712.GI30902@calimero.vinschen.de> <20170705180137.GJ30902@calimero.vinschen.de> From: Brian Inglis Message-ID: <0f10eb73-d25f-b225-16a7-059063d0899c@SystematicSw.ab.ca> Date: Wed, 05 Jul 2017 18:35:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170705180137.GJ30902@calimero.vinschen.de> Content-Type: multipart/mixed; boundary="------------DCCF04DE3665B5F6BC6FF9ED" X-CMAE-Envelope: MS4wfPQwG9TTARTWr1Y5r2fZLe+bftVRc3rO1jeF3T1UGpiFb5cmy0/7TQwOULJ7N76aEHJfKlKCOHw2IyMUE6zZvOOQfVHrx7qqdb7SxIAOSG6EyLW9ZWJ7 4pdcT0d75uf3VuMKb8qw7ug3EMBjXvxL2cE79fN2GOFlWmk0UP9dVrremTAPFONhaVFpH4frhZMbHw== X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00023.txt.bz2 This is a multi-part message in MIME format. --------------DCCF04DE3665B5F6BC6FF9ED Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 1612 On 2017-07-05 12:01, Corinna Vinschen wrote: > On Jul 5 13:44, Ken Brown wrote: >> On 7/5/2017 1:27 PM, Corinna Vinschen wrote: >>> On Jul 5 11:20, Brian Inglis wrote: >>>> On 2017-07-05 08:27, Corinna Vinschen wrote: >>>>> On Jul 5 13:32, Nellis, Kenneth wrote: >>>>>> So, these are handy links to have, I guess, but is it appropriate for >>>>>> cygwin-doc.sh to presume that the directory exists? Maybe it should create it >>>>>> rather than simply bail out and complain if it doesn't exist. >>>>> >>>>> In theory, the script should only create the files if the directory >>>>> exists. Brian? >>>> >>>> Okay - assumed the directory would always be created by setup - >>>> presumably not true - but do not check that assumption in pi, although >>>> thought about it - >>> >>> User's can decline creating shortcuts in setup. >>> >>>> should I check and skip creating shortcuts, rather than create dir and >>>> shorcuts? Should I also check and skip rm in prerm? And provide >>>> patches? >>> >>> Skipping goes hand in hand with the fact that the user declined the >>> Start Menu shortcut creation. >> >> The script already does check and skip. The only issue is that it skips by >> calling 'exit 2' instead of 'exit 0', which is what led to the original >> post. > > Note to myself: read source before talking about it. Patch(es) attached - shuffled the order of a few things to fail quietly in postinstall - changed preremove to look and take a similar approach to postinstall for consistency - format-patch should apply cleanly this time. -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada --------------DCCF04DE3665B5F6BC6FF9ED Content-Type: text/plain; charset=UTF-8; name="0001-fix-cygwin-doc-postinstall-preremove-no-SMPrograms-C.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-fix-cygwin-doc-postinstall-preremove-no-SMPrograms-C.pa"; filename*1="tch" Content-length: 5507 RnJvbSA5MmEzZGQzN2RjOWYwZGE2NWY5NTg3MDdkOTNkOWUxMWI2MDQ3YmQ4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBCcmlhbiBJbmdsaXMg PEJyaWFuLkluZ2xpc0BTeXN0ZW1hdGljU1cuYWIuY2E+CkRhdGU6IFdlZCwg NSBKdWwgMjAxNyAxMjoyODo1NCAtMDYwMApTdWJqZWN0OiBbUEFUQ0hdIGZp eCBjeWd3aW4tZG9jIHBvc3RpbnN0YWxsL3ByZXJlbW92ZSBubyBTTVByb2dy YW1zL0N5Z3dpbiBkaXIKCi0tLQogd2luc3VwL2RvYy9ldGMucG9zdGluc3Rh bGwuY3lnd2luLWRvYy5zaCB8IDM1ICsrKysrKysrKysrKysrKy0tLS0tLS0t LS0KIHdpbnN1cC9kb2MvZXRjLnByZXJlbW92ZS5jeWd3aW4tZG9jLnNoICAg fCA0NSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLQogMiBmaWxl cyBjaGFuZ2VkLCA2MyBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS93aW5zdXAvZG9jL2V0Yy5wb3N0aW5zdGFsbC5jeWd3 aW4tZG9jLnNoIGIvd2luc3VwL2RvYy9ldGMucG9zdGluc3RhbGwuY3lnd2lu LWRvYy5zaAppbmRleCAzYTk0NTdmYmIuLjFkNDFlZjBjMSAxMDA3NTUKLS0t IGEvd2luc3VwL2RvYy9ldGMucG9zdGluc3RhbGwuY3lnd2luLWRvYy5zaAor KysgYi93aW5zdXAvZG9jL2V0Yy5wb3N0aW5zdGFsbC5jeWd3aW4tZG9jLnNo CkBAIC02LDM1ICs2LDQyIEBACiAjIENZR1dJTkZPUkFMTD0tQSBpZiBpbnN0 YWxsIGZvciBBbGwgVXNlcnMKICMgaW5zdGFsbHMgbG9jYWwgc2hvcnRjdXRz IGZvciBBbGwgVXNlcnMgb3IgQ3VycmVudCBVc2VyIGluCiAjIHtQcm9ncmFt RGF0YSx+L0FwcGRhdGEvUm9hbWluZ30vTWljcm9zb2Z0L1dpbmRvd3MvU3Rh cnQgTWVudS9Qcm9ncmFtcy9DeWd3aW4vCisjIGV4aXRzIHF1aWV0bHkgaWYg ZGlyZWN0b3J5IGRvZXMgbm90IGV4aXN0IGFzIHByZXN1bWFibHkgbm8gc2hv cnRjdXRzIGRlc2lyZWQKIAorZG9jPS91c3Ivc2hhcmUvZG9jL2N5Z3dpbi1k b2MKK3NpdGU9aHR0cHM6Ly9jeWd3aW4uY29tCiBjeWdwPS9iaW4vY3lncGF0 aAogbWtzPS9iaW4vbWtzaG9ydGN1dAotdW49L2Jpbi91bmFtZQotc2l0ZT1o dHRwczovL2N5Z3dpbi5jb20KIAotIyBjaGVjayBmb3IgcHJvZ3JhbXMKLWZv ciBwIGluICR1biAkY3lncCAkbWtzCitodG1sPSRkb2MvaHRtbAorCisjIGNo ZWNrIHNvdXJjZSBkaXJlY3RvcmllcyBjcmVhdGVkCitmb3IgZCBpbiAkZG9j ICRodG1sCiBkbwotCWlmIFsgISAteCAkcCBdCisJaWYgWyAhIC1kICIkZC8i IF0KIAl0aGVuCi0JCWVjaG8gIkNhbid0IGZpbmQgcHJvZ3JhbSAnJHAnIgor CQllY2hvICJDYW4ndCBmaW5kIGRpcmVjdG9yeSAnJGQnIgogCQlleGl0IDIK IAlmaQogZG9uZQogCi1kb2M9L3Vzci9zaGFyZS9kb2MvY3lnd2luLWRvYwot aHRtbD0kZG9jL2h0bWwKLXNtcGNfZGlyPSIkKCRjeWdwICRDWUdXSU5GT1JB TEwgLVAgLVUpL0N5Z3dpbiIKLQotZm9yIGQgaW4gJGRvYyAkaHRtbCAiJHNt cGNfZGlyIgorIyBjaGVjayBmb3IgcHJvZ3JhbXMKK2ZvciBwIGluICRjeWdw ICRta3MKIGRvCi0JaWYgWyAhIC1kICIkZC8iIF0KKwlpZiBbICEgLXggJHAg XQogCXRoZW4KLQkJZWNobyAiQ2FuJ3QgZmluZCBkaXJlY3RvcnkgJyRkJyIK KwkJZWNobyAiQ2FuJ3QgZmluZCBwcm9ncmFtICckcCciCiAJCWV4aXQgMgog CWZpCiBkb25lCiAKKyMgQ3lnd2luIFN0YXJ0IE1lbnUgZGlyZWN0b3J5Citz bXBjX2Rpcj0iJCgkY3lncCAkQ1lHV0lORk9SQUxMIC1QIC1VIC0tKS9DeWd3 aW4iCisKKyMgY2hlY2sgQ3lnd2luIFN0YXJ0IE1lbnUgZGlyZWN0b3J5IHN0 aWxsIGV4aXN0cworWyAtZCAiJHNtcGNfZGlyLyIgXSB8fCBleGl0IDAKKwor IyBjaGVjayBDeWd3aW4gU3RhcnQgTWVudSBkaXJlY3Rvcnkgd3JpdGFibGUK IGlmIFsgISAtdyAiJHNtcGNfZGlyLyIgXQogdGhlbgogCWVjaG8gIkNhbid0 IHdyaXRlIHRvIGRpcmVjdG9yeSAnJHNtcGNfZGlyJyIKQEAgLTQyLDcgKzQ5 LDcgQEAgdGhlbgogZmkKIAogIyBta3Nob3J0Y3V0IHdvcmtzIG9ubHkgaW4g Y3VycmVudCBkaXJlY3RvcnkgLSBjaGFuZ2UgdG8gQ3lnd2luIFN0YXJ0IE1l bnUKLWNkICIkc21wY19kaXIiIHx8IGV4aXQgMgkjIHF1aXQgaWYgbm90IGZv dW5kCitjZCAiJHNtcGNfZGlyLyIgfHwgZXhpdCAwCSMgcXVpdCBpZiBub3Qg Zm91bmQKIAogIyBjcmVhdGUgVXNlciBHdWlkZSBhbmQgQVBJIFBERiBhbmQg SFRNTCBzaG9ydGN1dHMKIHdoaWxlIHJlYWQgdGFyZ2V0IG5hbWUgZGVzYwpk aWZmIC0tZ2l0IGEvd2luc3VwL2RvYy9ldGMucHJlcmVtb3ZlLmN5Z3dpbi1k b2Muc2ggYi93aW5zdXAvZG9jL2V0Yy5wcmVyZW1vdmUuY3lnd2luLWRvYy5z aAppbmRleCA4MTdkNmQ2OGUuLjA5ZTBjOWVmYyAxMDA3NTUKLS0tIGEvd2lu c3VwL2RvYy9ldGMucHJlcmVtb3ZlLmN5Z3dpbi1kb2Muc2gKKysrIGIvd2lu c3VwL2RvYy9ldGMucHJlcmVtb3ZlLmN5Z3dpbi1kb2Muc2gKQEAgLTYsOSAr Niw0OCBAQAogIyBDWUdXSU5GT1JBTEw9LUEgaWYgcmVtb3ZlIGZvciBBbGwg VXNlcnMKICMgcmVtb3ZlIGxvY2FsIHNob3J0Y3V0cyBmb3IgQWxsIFVzZXJz IG9yIEN1cnJlbnQgVXNlciBpbgogIyB7UHJvZ3JhbURhdGEsfi9BcHBkYXRh L1JvYW1pbmd9L01pY3Jvc29mdC9XaW5kb3dzL1N0YXJ0IE1lbnUvUHJvZ3Jh bXMvQ3lnd2luLworIyBleGl0cyBxdWlldGx5IGlmIGRpcmVjdG9yeSBkb2Vz IG5vdCBleGlzdCBhcyBwcmVzdW1hYmx5IG5vIHNob3J0Y3V0cyBkZXNpcmVk CiAKLWNkICIkKC9iaW4vY3lncGF0aCAkQ1lHV0lORk9SQUxMIC1QIC1VKS9D eWd3aW4iIHx8IGV4aXQgMgorZG9jPS91c3Ivc2hhcmUvZG9jL2N5Z3dpbi1k b2MKK2N5Z3A9L2Jpbi9jeWdwYXRoCitybT0vYmluL3JtCiAKLS9iaW4vcm0g LWYgLS0gIlVzZXIgR3VpZGUgKFBERikubG5rIiAiVXNlciBHdWlkZSAoSFRN TCkubG5rIiBcCi0JIkFQSSAoUERGKS5sbmsiICJBUEkgKEhUTUwpLmxuayIg IkhvbWUgUGFnZS5sbmsiICJGQVEubG5rIgoraHRtbD0kZG9jL2h0bWwKKwor IyBjaGVjayBmb3IgcHJvZ3JhbXMKK2ZvciBwIGluICRjeWdwICRybQorZG8K KwlpZiBbICEgLXggJHAgXQorCXRoZW4KKwkJZWNobyAiQ2FuJ3QgZmluZCBw cm9ncmFtICckcCciCisJCWV4aXQgMgorCWZpCitkb25lCisKKyMgQ3lnd2lu IFN0YXJ0IE1lbnUgZGlyZWN0b3J5CitzbXBjX2Rpcj0iJCgkY3lncCAkQ1lH V0lORk9SQUxMIC1QIC1VIC0tKS9DeWd3aW4iCisKKyMgY2hlY2sgQ3lnd2lu IFN0YXJ0IE1lbnUgZGlyZWN0b3J5IHN0aWxsIGV4aXN0cworWyAtZCAiJHNt cGNfZGlyLyIgXSB8fCBleGl0IDAKKworIyBjaGVjayBDeWd3aW4gU3RhcnQg TWVudSBkaXJlY3Rvcnkgd3JpdGFibGUKK2lmIFsgISAtdyAiJHNtcGNfZGly LyIgXQordGhlbgorCWVjaG8gIkNhbid0IHdyaXRlIHRvIGRpcmVjdG9yeSAn JHNtcGNfZGlyJyIKKwlleGl0IDEKK2ZpCisKKyMgcmVtb3ZlIFVzZXIgR3Vp ZGUgYW5kIEFQSSBQREYgYW5kIEhUTUwsIEhvbWUgUGFnZSBhbmQgRkFRIFVS TCBsaW5rIHNob3J0Y3V0cword2hpbGUgcmVhZCB0YXJnZXQgbmFtZSBkZXNj CitkbworCWxuaz0iJHNtcGNfZGlyLyRuYW1lLmxuayIKKwlbIC1mICIkbG5r IiBdICYmICRybSAtZiAtLSAiJGxuayIKK2RvbmUgPDxFT0YKKyRkb2MvY3ln d2luLXVnLW5ldC5wZGYJCVVzZXJcIEd1aWRlXCBcKFBERlwpICBDeWd3aW5c IFVzZXJcIEd1aWRlXCBQREYKKyRodG1sL2N5Z3dpbi11Zy1uZXQvaW5kZXgu aHRtbAlVc2VyXCBHdWlkZVwgXChIVE1MXCkgQ3lnd2luXCBVc2VyXCBHdWlk ZVwgSFRNTAorJGRvYy9jeWd3aW4tYXBpLnBkZgkJQVBJXCBcKFBERlwpCUN5 Z3dpblwgQVBJXCBSZWZlcmVuY2VcIFBERgorJGh0bWwvY3lnd2luLWFwaS9p bmRleC5odG1sCUFQSVwgXChIVE1MXCkJQ3lnd2luXCBBUElcIFJlZmVyZW5j ZVwgSFRNTAorJHNpdGUvaW5kZXguaHRtbAlIb21lXCBQYWdlCUN5Z3dpblwg SG9tZVwgUGFnZVwgTGluaworJHNpdGUvZmFxLmh0bWwJCUZBUQlDeWd3aW5c IEZyZXF1ZW50bHlcIEFza2VkXCBRdWVzdGlvbnNcIExpbmsKK0VPRgogCi0t IAoyLjEyLjMKCg== --------------DCCF04DE3665B5F6BC6FF9ED--