From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-a1p-077725.sys.comcast.net (resqmta-a1p-077725.sys.comcast.net [IPv6:2001:558:fd01:2bb4::b]) by sourceware.org (Postfix) with ESMTPS id 628C5385702C for ; Sun, 23 Oct 2022 19:13:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 628C5385702C Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=acm.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=acm.org Received: from resomta-a1p-077060.sys.comcast.net ([96.103.145.238]) by resqmta-a1p-077725.sys.comcast.net with ESMTP id mgKjo9QKddCVXmgPhojyhl; Sun, 23 Oct 2022 19:13:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcastmailservice.net; s=20211018a; t=1666552417; bh=HysdHDqQwDWILEEsIJalXX8uzdapiNbBuTPQ7CUGAqc=; h=Received:Received:Message-ID:Date:MIME-Version:Subject:To:From: Content-Type; b=CDN7lBt/lGUVefwvkfv4SjAFvmdSYH9fOXyUts8HgbFJBbYOfPeOQP43OIuNV3uGs T2O8IKh0aIIWRg/x38A9eY128levGTB9h0uuMZHC166BNVgcRMaTeAofAyurks/GQd CqPHr7SajNjKzHAPXi2z4et4uKIuWGmHyFVH3Fp01q27PwpURzfJ/aj1ovBSbvPrFu uEAqcKheBSQC0c6kQ0FP/1iMLhxjaB3QcDZSomjt/4lao8z8SUWf8ryNfwDVeu4jov TNnRyjAmbR7v2te0BMbjJdMg7kkOmA65aZUpipmQGDAyD8hLrHftp4DV+JEmYO3c1B xKu0dk8RkLBNw== Received: from [IPV6:2601:547:c500:dbe:9dea:8c0e:d5c9:65e4] ([IPv6:2601:547:c500:dbe:9dea:8c0e:d5c9:65e4]) by resomta-a1p-077060.sys.comcast.net with ESMTPSA id mgPEohMkDbG4ymgPKoEp4q; Sun, 23 Oct 2022 19:13:15 +0000 X-Xfinity-VMeta: sc=-100.00;st=legit Message-ID: <0fe82c85-b6f2-6c9a-6529-dbf42647498a@acm.org> Date: Sun, 23 Oct 2022 15:13:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [ITP] passwdqc 2.0.2 Content-Language: en-US To: Adam Dinwoodie , "cygwin-apps@cygwin.com" References: <5b094255-37c5-1662-a810-c60972c44f5c@acm.org> From: Chad Dougherty In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_DMARC_NONE,KAM_NUMSUBJECT,NICE_REPLY_A,SPF_HELO_PASS,SPF_SOFTFAIL,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-10-23 13:42, Adam Dinwoodie wrote: >> .hint and .cygport files are attached and can also be found here along >> with built packages: >> https://github.com/crd477/passwdqc-cygport > > Mostly looks good to me, but I think there are a couple of errors: > > - etc/passwdqc.conf and usr/share/man/man5/passwdqc.conf.5.gz look to > me like they belong in the libpasswdqc0 package > Ah, you're right. Good catch. Fixed in the working repo I mentioned above. > - The usr/share/man/man3/passwdqc_* man pages are all empty > I can't reproduce this and they all look OK in my local environment. By any chance do you have a pointer to a public artifact where it occurs? To be sure, these man pages should be identical for each passwdqc function but they should not be empty. Thanks for reviewing this. I really appreciate it, especially while I'm still getting familiar with this process. -- -Chad