From: Ken Brown <kbrown@cornell.edu>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH setup] Finish providing support for provides: and conflicts:
Date: Fri, 06 Jul 2018 22:19:00 -0000 [thread overview]
Message-ID: <11e826c2-420f-103a-f600-38e757e61afb@cornell.edu> (raw)
In-Reply-To: <e50cc9fd-66c7-17c6-b367-5a8fb0e15ce6@dronecode.org.uk>
On 7/6/2018 12:28 PM, Jon Turney wrote:
> On 23/06/2018 16:09, Ken Brown wrote:
>>> I'll try again to reproduce this, but it might be a few days until I
>>> can get to it.
>>
>> Here's a recipe for reproducing the problem:
>>
>> 1. Create a repository with two packages, A and B, and two versions
>> 1-1 and 2-1 of each. Make A-1-1 require B>=1, and make A-2-1 require
>> B>=2. The attached script does all this.
>>
>> 2. Run setup on this repo and install A-1-1 and B-1-1.
>>
>> 3. Run setup again. It will offer to update both A and B. Choose to
>> keep B and press 'Next'.
>>
>> setup built from the current HEAD correctly reports the dependency
>> problem. But if I apply my patch, then setup doesn't report the
>> problem and lets me proceed to update A without updating B.
> Thanks very much for this testcase, it helped a lot.
>
> This looks like completely my fault:Â SolvableVersion::deplist()'s
> handling of dependencies with a version relation was completely bogus.
Great. I'm glad the problem turned out to have an easy fix.
> So provides() on B was always returning unversioned B, rather than
> B-1-1, so the installed B ended up with that as provides, which appears
> to be enough to satisfy a depends of B-2-1.
>
> (previously we'd just have the correct, implicit provide made at
> libsolv.cpp:472)
>
> Attached patch seems to make it work.
I can confirm that it fixes my testcase.
Ken
prev parent reply other threads:[~2018-07-06 22:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 19:38 Ken Brown
2018-04-04 13:21 ` Ken Brown
2018-06-06 20:44 ` Jon Turney
[not found] ` <6fb8aceb-7a04-36e8-c14f-4d182bd27e1e@dronecode.org.uk>
2018-06-18 17:49 ` Ken Brown
2018-06-19 12:43 ` Ken Brown
2018-06-23 15:10 ` Ken Brown
2018-07-06 16:28 ` Jon Turney
2018-07-06 22:19 ` Ken Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11e826c2-420f-103a-f600-38e757e61afb@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).