public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: setup: problems with local install
Date: Tue, 06 Mar 2018 22:13:00 -0000	[thread overview]
Message-ID: <127b9506-8319-974c-e583-da8e2425fdaa@dronecode.org.uk> (raw)
In-Reply-To: <a26d9e73-e436-786f-62bd-05bb3b4dd569@cornell.edu>

On 06/03/2018 19:31, Ken Brown wrote:
> On 3/6/2018 10:18 AM, Jon Turney wrote:
>> (I also note we have also have another 'erase an element from a vector 
>> while we are iterating over it' here, so that needs fixing, as well)
> 
> I think this one might be OK.  If I'm not mistaken, 
> pkg.versions.erase(i++) passes a copy of i to erase, and then increments 
> i before erase() has done its work.  But I'm no expert on this.

I think that's still not ok for a vector, but this is actually a set, so 
there's actually no problem.

See e.g. [1], or refer to your copy of the C++ standard :)

[1] https://stackoverflow.com/questions/6438086/iterator-invalidation-rules

  reply	other threads:[~2018-03-06 22:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-05 18:34 Ken Brown
2018-03-06  2:18 ` Ken Brown
2018-03-06 16:38   ` Jon Turney
2018-03-06 15:18 ` Jon Turney
2018-03-06 18:47   ` Jon Turney
2018-03-07 21:53     ` Ken Brown
2018-03-08 15:59       ` Ken Brown
2018-03-08 21:59         ` Ken Brown
2018-03-12 13:22           ` Ken Brown
2018-03-14 16:07             ` Jon Turney
2018-03-14 19:25               ` Ken Brown
2018-03-15 21:02                 ` Jon Turney
2018-03-06 19:31   ` Ken Brown
2018-03-06 22:13     ` Jon Turney [this message]
2018-03-07  7:32     ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=127b9506-8319-974c-e583-da8e2425fdaa@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).