Re: setup 2.886 release candidate - please test

[Jon Turney <jon.turney@dronecode.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

On 02/02/2018 19:38, Achim Gratz wrote:
> Jon Turney writes:
>>> Do you have an idea yet why the last package gets orphaned (or did, if
>>
>> 'Yet'?  This is the first time I've heard of this!
> 
> Right you are.  I thought I had mentioned it already, but forgot since I
> can't post from work.
> 
>> Is this regression?
> 
> Yes.
> 
>>> it's already fixed)?  I will need to remove my workaround of placing an
>>> empty dummy at the end to try.
>>
>> I guess you are saying that the last package listed in setup.ini
>> appears as orphaned, when you have a re-written setup.ini which only
>> contains one version per package?
> 
> I've tested that again today.  The last package gets orphaned if there
> is only a current section.  I believe that the last section is also not
> processed, so in the standard Cygwin installation you'd not be able to
> see the previous version of _update-info-dir.
> 
>> Which I can easily believe happens, due to the rather weird way that
>> the data from a parser reduction is transferred into the package
>> database.

Can you test the attached patch, please?


[-- Attachment #2: 0001-Make-sure-we-process-the-last-version-description-in.patch --]
[-- Type: text/plain, Size: 605 bytes --]

From 467a8839a34b6bc7e88ad181bb5c4b089f297d47 Mon Sep 17 00:00:00 2001
From: Jon Turney <jon.turney@dronecode.org.uk>
Date: Fri, 2 Feb 2018 19:41:58 +0000
Subject: [PATCH setup] Make sure we process the last version description in
 setup.ini

---
 IniDBBuilderPackage.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/IniDBBuilderPackage.cc b/IniDBBuilderPackage.cc
index 4169634..8fa6ad9 100644
--- a/IniDBBuilderPackage.cc
+++ b/IniDBBuilderPackage.cc
@@ -36,6 +36,7 @@ currentSpec (0), _feedback (aFeedback){}
 
 IniDBBuilderPackage::~IniDBBuilderPackage()
 {
+  process();
 }
 
 void
-- 
2.16.1