From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27359 invoked by alias); 4 Nov 2011 15:12:13 -0000 Received: (qmail 27339 invoked by uid 22791); 4 Nov 2011 15:12:11 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_KG X-Spam-Check-By: sourceware.org Received: from mail-vx0-f171.google.com (HELO mail-vx0-f171.google.com) (209.85.220.171) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Nov 2011 15:11:52 +0000 Received: by vcbfk14 with SMTP id fk14so1701010vcb.2 for ; Fri, 04 Nov 2011 08:11:52 -0700 (PDT) Received: by 10.52.94.102 with SMTP id db6mr13696600vdb.118.1320419511961; Fri, 04 Nov 2011 08:11:51 -0700 (PDT) Received: from [192.168.0.100] (S0106000cf16f58b1.wp.shawcable.net. [24.79.200.150]) by mx.google.com with ESMTPS id et7sm13924598vdc.18.2011.11.04.08.11.50 (version=SSLv3 cipher=OTHER); Fri, 04 Nov 2011 08:11:51 -0700 (PDT) Subject: Re: [ITP] astrometry.net-0.38-1 From: "Yaakov (Cygwin/X)" To: cygwin-apps Date: Fri, 04 Nov 2011 15:12:00 -0000 In-Reply-To: <4EB3865A.2060400@cwilson.fastmail.fm> References: <6r0p87d36jnok922ec2mkfjqpog218994j@4ax.com> <4E8F0AA2.4060402@gmail.com> <4EB3865A.2060400@cwilson.fastmail.fm> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Message-ID: <1320419515.7560.10.camel@YAAKOV04> Mime-Version: 1.0 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com X-SW-Source: 2011-11/txt/msg00023.txt.bz2 On Fri, 2011-11-04 at 02:29 -0400, Charles Wilson wrote: > On 10/7/2011 12:18 PM, Jussi Kantola wrote: > > However I had to modify backend-main.c so that the config file (which > > defines the location of index files) > > could be read from cygwin's preferred location, > > /usr/share/astrometry/etc/backend.cfg. > > That's a little odd, and I don't think that's exactly what was meant by > the documentation http://cygwin.com/setup.html#package_contents. > > I don't think this is a showstopper for this release, but ordinarily > configuration files belong in the top-level /etc directory. However, > once installed there, a name like "backend.cfg" is poorly chosen, since > it doesn't really indicate what package it belongs to, and thus might > conflict with some other package. Then this should be /etc/astrometry/backend.cfg instead. > IOW, cygwin python's distutils is _doing the right thing_ -- creating > the plugin with the name spherematch_c.dll -- but the Makefile in > astrometry.net thinks the plugin will always be named spherematch_c.so > and reports an error when it tries to install the latter file. So patch the Makefile.in. > Now, this bit is interesting: > - mkdir -p $(INSTALL_DIR)/python/astrometry/libkd > + mkdir -p $(INSTALL_DIR)/share/astrometry/python/astrometry/libkd > > Normally, python extensions go under the "real" python dir: > > /usr/lib/python2.6/site-packages//... > > But...this whole build system doesn't really support that; it hardcodes > the destination path and then adds that path to sys.path via the > "application" .py files; when it really should use some mechanism to > find the entry in $python's sys.path list which contains "site-packages". > > So...accepting that, the python stuff should ALSO go under /lib rather > than /share, because (a) the .pyc files are platform specific, and (b) > the .dll's which ought to go there are also platform specific. I'm not so sure about (a), but my Linux VMs already use Python 2.7 so I couldn't check. That aside, I have no problem with application-specific pure-Python code in /usr/share/$PN, as they serve no purpose outside the given application, and many packages do this, in fact. Obviously DLL extensions can't go there though. > ....so, not GTG. Also, you missed Corinna's statement: "If the binaries > are using it (the libbackend library), they should also be linked > against [the DLL], rather than being linked statically." > > Your build still links against libbackend.a, rather than cygbackend.dll. > > I'm trying to massage your -src package to DTRT. Stay tuned. Good luck, it sounds like this software is quite unpolished. No wonder it's not in the distros yet. Yaakov