Re: HEADSUP: Packages with obsolete dependencies

[Yaakov Selkowitz <yselkowitz@cygwin.com>]

On Wed, 2015-02-11 at 14:08 -0500, Andrew Schulman wrote:
> > sng                                          Andrew Schulman
> 
> ATM this won't build with libpng16.  The source was only patched last year for
> libpng15, and not by the main author.  I can't remember now where the patches
> came from - it wasn't me - but I'll see what I can find out.
> 
> If you want to look at the build, here are the cygport and patch files:
> 
> wget \
>  http://home.comcast.net/~andrex2/cygwin/sng/sng.cygport \
>  http://home.comcast.net/~andrex2/cygwin/sng/sng-ChangeLog.patch \
>  http://home.comcast.net/~andrex2/cygwin/sng/sng-sngc.patch \
>  http://home.comcast.net/~andrex2/cygwin/sng/sng-sngd.patch \
>  http://home.comcast.net/~andrex2/cygwin/sng/sng-usage.patch

I would leave the usage line as is, or add a second line with just sng
-V (without the [file...]), as sng -V [file...] is a no-op.

> And the following files, taken from libpng15 I believe, have to be copied into
> the root of the build tree:
[snip]
> Don't ask me why, I don't remember and the patches were someone else's.  It
> worked.

https://cygwin.com/ml/cygwin-apps/2013-08/msg00083.html
https://sourceforge.net/p/cygwin-ports/sng/ci/55b820b/tree/

However, we want to use libpng16 nowadays instead of libpng15, and the
similar hack with libpng16's headers indeed does NOT work.  So this is
(a hopefully rare) case where an older libpng is required.  Given the
options, I would prefer to keep libpng12 for this case.  I have uploaded
libpng12 for x86_64, and you'll need a few tweaks to force the build to
use it:

https://sourceforge.net/p/cygwin-ports/sng/

> ATM the build is failing with:
> 
> gcc -DHAVE_CONFIG_H -I.
> -I/home/andrex/dev/cygwin/sng/sng-1.0.6-2.x86_64/src/sng-1.0.6     -ggdb -O2
> -pipe -Wimplicit-function-declaration
> -fdebug-prefix-map=/home/andrex/dev/cygwin/sng/sng-1.0.6-2.x86_64/build=/usr/src/debug/sng-1.0.6-2
> -fdebug-prefix-map=/home/andrex/dev/cygwin/sng/sng-1.0.6-2.x86_64/src/sng-1.0.6=/usr/src/debug/sng-1.0.6-2
> -MT sngd.o -MD -MP -MF .deps/sngd.Tpo -c -o sngd.o
> /home/andrex/dev/cygwin/sng/sng-1.0.6-2.x86_64/src/sng-1.0.6/sngd.c
> /home/andrex/dev/cygwin/sng/sng-1.0.6-2.x86_64/src/sng-1.0.6/main.c: In function
> ‘fatal’:
> /home/andrex/dev/cygwin/sng/sng-1.0.6-2.x86_64/src/sng-1.0.6/main.c:43:5:
> warning: implicit declaration of function 'strlen'
> [-Wimplicit-function-declaration]
>      vsprintf(buf + strlen(buf), fmt, ap);
>      ^
> /home/andrex/dev/cygwin/sng/sng-1.0.6-2.x86_64/src/sng-1.0.6/main.c:43:20:
> warning: incompatible implicit declaration of built-in function 'strlen'

main.c is missing an #include <string.h>.

HTH,
--
Yaakov