From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-apps@cygwin.com
Cc: Jon Turney <jon.turney@dronecode.org.uk>
Subject: [PATCH setup 2/3] Remove unfinished, unused support for 'autodep:' lines in setup.ini
Date: Tue, 22 Sep 2015 15:53:00 -0000 [thread overview]
Message-ID: <1442937170-17580-3-git-send-email-jon.turney@dronecode.org.uk> (raw)
In-Reply-To: <1442937170-17580-1-git-send-email-jon.turney@dronecode.org.uk>
This effectively reverts the parts of commits
9b98ba2301658c34d0e9c3fd4bbd964ce52ef8ae and
dd15057d785045dfc1395ed5f39c84bcdcb88b13 which add that.
* IniDBBuilder.h (IniDBBuilder::autodep): Remove.
* IniDBBuilderPackage.cc (IniDBBuilderPackage::autodep): Remove.
* IniDBBuilderPackage.h (IniDBBuilderPackage::autodep): Remove.
* cygpackage.cc (cygpackage::set_autodep): Remove.
* cygpackage.h (cygpackage::set_autodep): Remove.
* inilex.ll: Remove autodep.
* iniparse.yy: Remove autodep.
* package_version.cc (packageversion::set_autodep): Remove.
* package_version.h (packageversion::set_autodep): Remove.
Signed-off-by: Jon Turney <jon.turney@dronecode.org.uk>
---
ChangeLog | 12 ++++++++++++
IniDBBuilder.h | 1 -
IniDBBuilderPackage.cc | 6 ------
IniDBBuilderPackage.h | 1 -
cygpackage.cc | 6 ------
cygpackage.h | 2 --
inilex.ll | 1 -
iniparse.yy | 3 +--
package_version.cc | 7 -------
package_version.h | 2 --
10 files changed, 13 insertions(+), 28 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 8c6fd3a..4a6b3b8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,17 @@
2015-09-18 Jon Turney <jon.turney@dronecode.org.uk>
+ * IniDBBuilder.h (IniDBBuilder::autodep): Remove.
+ * IniDBBuilderPackage.cc (IniDBBuilderPackage::autodep): Remove.
+ * IniDBBuilderPackage.h (IniDBBuilderPackage::autodep): Remove.
+ * cygpackage.cc (cygpackage::set_autodep): Remove.
+ * cygpackage.h (cygpackage::set_autodep): Remove.
+ * inilex.ll: Remove autodep.
+ * iniparse.yy: Remove autodep.
+ * package_version.cc (packageversion::set_autodep): Remove.
+ * package_version.h (packageversion::set_autodep): Remove.
+
+2015-09-18 Jon Turney <jon.turney@dronecode.org.uk>
+
* Makefile.am (AM_CPPFLAGS): Remove regex from include path.
(@SETUP@_SOURCES): Remove regex.c.
* regex/config.h: Delete file.
diff --git a/IniDBBuilder.h b/IniDBBuilder.h
index 3477981..0756d91 100644
--- a/IniDBBuilder.h
+++ b/IniDBBuilder.h
@@ -60,7 +60,6 @@ public:
virtual void buildPackageListOperator (PackageSpecification::_operators const &) = 0;
virtual void buildPackageListOperatorVersion (const std::string& ) = 0;
virtual void buildMessage (const std::string&, const std::string&) = 0;
- virtual void autodep (const std::string&, const std::string&) = 0;
void set_arch (const std::string& a) { arch = a; }
void set_release (const std::string& rel) { release = rel; }
diff --git a/IniDBBuilderPackage.cc b/IniDBBuilderPackage.cc
index ff92ec2..b75d0fd 100644
--- a/IniDBBuilderPackage.cc
+++ b/IniDBBuilderPackage.cc
@@ -626,9 +626,3 @@ IniDBBuilderPackage::buildMessage (const std::string& message_id, const std::str
{
cp->set_message (message_id, message);
}
-
-void
-IniDBBuilderPackage::autodep (const std::string& file_regex, const std::string& message)
-{
- cbpv.set_autodep (file_regex);
-}
diff --git a/IniDBBuilderPackage.h b/IniDBBuilderPackage.h
index b19d440..7b9e0d6 100644
--- a/IniDBBuilderPackage.h
+++ b/IniDBBuilderPackage.h
@@ -62,7 +62,6 @@ public:
virtual void buildBeginBinary ();
virtual void buildDescription (const std::string&);
virtual void buildMessage (const std::string&, const std::string&);
- virtual void autodep (const std::string&, const std::string&);
virtual void buildSourceName (const std::string& );
virtual void buildSourceNameVersion (const std::string& );
virtual void buildPackageListAndNode ();
diff --git a/cygpackage.cc b/cygpackage.cc
index 74d040d..4b05cb3 100644
--- a/cygpackage.cc
+++ b/cygpackage.cc
@@ -193,12 +193,6 @@ cygpackage::set_sdesc (const std::string& desc)
}
void
-cygpackage::set_autodep (const std::string& autodep)
-{
- autodep_regex = autodep;
-}
-
-void
cygpackage::set_ldesc (const std::string& desc)
{
ldesc = desc;
diff --git a/cygpackage.h b/cygpackage.h
index c00539b..0b08e0d 100644
--- a/cygpackage.h
+++ b/cygpackage.h
@@ -52,7 +52,6 @@ public:
{
return ldesc;
};
- virtual void set_autodep (const std::string& );
virtual void uninstall ();
@@ -86,7 +85,6 @@ private:
std::string canonical;
std::string fn;
std::string sdesc, ldesc;
- std::string autodep_regex;
char getfilenamebuffer[CYG_PATH_MAX];
// package_stability_t stability;
diff --git a/inilex.ll b/inilex.ll
index 67764f0..49bbfa6 100644
--- a/inilex.ll
+++ b/inilex.ll
@@ -119,7 +119,6 @@ B64 [a-zA-Z0-9_-]
"sdesc:" return SDESC;
"ldesc:" return LDESC;
"message:" return MESSAGE;
-"autodep:" return AUTODEP;
"Description:" BEGIN (descriptionstate); return DESCTAG;
"Size:" return FILESIZE;
"MD5sum:" return MD5LINE;
diff --git a/iniparse.yy b/iniparse.yy
index 5fd6c3f..da3e5d0 100644
--- a/iniparse.yy
+++ b/iniparse.yy
@@ -51,7 +51,7 @@ void add_correct_version();
%token OPENBRACE CLOSEBRACE EQUAL GT LT GTEQUAL LTEQUAL
%token OPENSQUARE CLOSESQUARE
%token BINARYPACKAGE BUILDDEPENDS STANDARDSVERSION FORMAT DIRECTORY FILES
-%token MESSAGE AUTODEP
+%token MESSAGE
%token ARCH RELEASE
%%
@@ -125,7 +125,6 @@ singleitem /* non-empty */
| BUILDDEPENDS { iniBuilder->buildBeginBuildDepends(); } versionedpackagelist NL
| FILES NL SourceFilesList
| MESSAGE STRING STRING NL { iniBuilder->buildMessage ($2, $3); }
- | AUTODEP STRING STRING NL { iniBuilder->autodep ($2, $3); }
| DESCTAG mlinedesc
| error { yyerror (std::string("unrecognized line ")
+ stringify(yylineno)
diff --git a/package_version.cc b/package_version.cc
index 7340913..c7d9d24 100644
--- a/package_version.cc
+++ b/package_version.cc
@@ -58,7 +58,6 @@ public:
void set_sdesc (const std::string& ) {}
const std::string LDesc () {return std::string();}
void set_ldesc (const std::string& ) {}
- void set_autodep (const std::string& ) {}
void uninstall (){}
void pick(bool const &newValue){/* Ignore attempts to pick this!. Throw an exception here if you want to detect such attemtps instead */}
virtual void addScript(Script const &) {}
@@ -218,12 +217,6 @@ packageversion::set_ldesc (const std::string& ldesc)
data->set_ldesc (ldesc);
}
-void
-packageversion::set_autodep (const std::string& regex)
-{
- data->set_autodep (regex);
-}
-
packageversion
packageversion::sourcePackage() const
{
diff --git a/package_version.h b/package_version.h
index 7fcdaeb..32700f0 100644
--- a/package_version.h
+++ b/package_version.h
@@ -113,7 +113,6 @@ public:
void set_sdesc (const std::string& );
const std::string LDesc () const;
void set_ldesc (const std::string& );
- void set_autodep (const std::string& );
packageversion sourcePackage () const;
PackageSpecification & sourcePackageSpecification ();
void setSourcePackageSpecification (PackageSpecification const &);
@@ -179,7 +178,6 @@ public:
virtual void set_sdesc (const std::string& ) = 0;
virtual const std::string LDesc () = 0;
virtual void set_ldesc (const std::string& ) = 0;
- virtual void set_autodep (const std::string& ) = 0;
/* only semantically meaningful for binary packages */
/* direct link to the source package for this binary */
/* if multiple versions exist and the source doesn't discriminate
--
2.5.3
next prev parent reply other threads:[~2015-09-22 15:53 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 15:53 [PATCH setup 0/3] Setup replacement for incver_ifdep Jon Turney
2015-09-22 15:53 ` [PATCH setup 3/3] Add support for 'trigger:' lines in setup.ini Jon Turney
2015-09-22 15:53 ` Jon Turney [this message]
2015-09-22 15:54 ` [PATCH setup 1/3] Remove unused regex code Jon Turney
2015-09-22 17:33 ` [PATCH setup 0/3] Setup replacement for incver_ifdep Achim Gratz
2015-09-23 17:17 ` Jon Turney
2015-09-23 18:09 ` Achim Gratz
2015-10-12 13:16 ` Jon Turney
2015-10-12 17:38 ` Achim Gratz
2015-10-15 13:18 ` Jon Turney
2015-10-15 18:01 ` Achim Gratz
2015-10-19 15:41 ` Corinna Vinschen
2015-10-19 17:21 ` Achim Gratz
2015-10-20 10:21 ` Corinna Vinschen
2015-11-23 15:14 ` Jon Turney
2015-11-23 18:54 ` Achim Gratz
2015-11-24 16:59 ` Jon Turney
2015-11-24 18:44 ` Achim Gratz
2015-11-26 10:11 ` Corinna Vinschen
2015-11-26 18:12 ` Achim Gratz
2016-01-28 17:33 ` Jon Turney
2016-01-28 18:06 ` Achim Gratz
2016-01-28 18:41 ` [GOLDSTAR] " Corinna Vinschen
2016-01-29 16:37 ` Andrew Schulman
2016-01-28 18:42 ` Ken Brown
2016-01-28 20:06 ` Eric Blake
2016-01-28 20:17 ` Ken Brown
2016-01-28 20:22 ` Eric Blake
2016-01-29 14:22 ` Jon Turney
2016-01-29 14:53 ` Ken Brown
2016-01-29 19:17 ` Achim Gratz
2016-01-29 21:34 ` Ken Brown
2016-02-06 14:29 ` Ken Brown
2016-02-06 15:31 ` Jon Turney
2016-02-06 15:52 ` Jon Turney
2015-11-23 15:14 ` Jon Turney
2015-10-19 15:33 ` [GOLDSTAR] " Corinna Vinschen
2015-10-19 21:06 ` Andrew Schulman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442937170-17580-3-git-send-email-jon.turney@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).