From: Eric Blake <eblake@redhat.com>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH] src_postinst.cygpart: Sanitize binary data in bash command subst
Date: Fri, 16 Dec 2016 20:47:00 -0000 [thread overview]
Message-ID: <1b76f874-ac46-8421-ab5e-a8dabcc712c8@redhat.com> (raw)
In-Reply-To: <20161216204052.5657-1-eblake@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 696 bytes --]
On 12/16/2016 02:40 PM, Eric Blake wrote:
> bash 4.4 now warns about skipping NUL bytes in $(command), since
> command substitution is only well-formed for commands that output
> text, but NUL bytes are not text. Silence the warning by removing
> NUL bytes from the stream before bash can see them.
> ---
As usual for me, I hit send too soon :) I should have mentioned that
this was a patch for cygport, based on the report here:
https://cygwin.com/ml/cygwin/2016-12/msg00182.html
The patch works fine on bash 4.3.x, and shuts up the new warning present
in bash 4.4.x
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-12-16 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 20:41 Eric Blake
2016-12-16 20:47 ` Eric Blake [this message]
2016-12-16 21:09 ` Eric Blake
2017-01-15 13:02 ` Achim Gratz
2017-01-17 23:02 ` Yaakov Selkowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b76f874-ac46-8421-ab5e-a8dabcc712c8@redhat.com \
--to=eblake@redhat.com \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).