From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id A14DC385E008 for ; Tue, 24 Mar 2020 14:24:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A14DC385E008 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=yselkowitz@cygwin.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-463-3xdqubJONAezz4MLsEN98g-1; Tue, 24 Mar 2020 10:24:18 -0400 X-MC-Unique: 3xdqubJONAezz4MLsEN98g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 48B018010CA for ; Tue, 24 Mar 2020 14:24:17 +0000 (UTC) Received: from ovpn-112-56.rdu2.redhat.com (ovpn-112-56.rdu2.redhat.com [10.10.112.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9C305C1B2 for ; Tue, 24 Mar 2020 14:24:16 +0000 (UTC) Message-ID: <1e08383d408b0363595e42f12b630d69cf4228bd.camel@cygwin.com> Subject: Re: Putting packages up for adoption From: Yaakov Selkowitz Reply-To: cygwin-apps@cygwin.com To: cygwin-apps@cygwin.com Date: Tue, 24 Mar 2020 10:24:15 -0400 In-Reply-To: References: <70c758ccf420ba3bd38997e1f6860c25a5b03138.camel@cygwin.com> User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: cygwin.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2020 14:24:22 -0000 On Tue, 2020-03-24 at 15:11 +0100, Jan Nijtmans via Cygwin-apps wrote: > Op di 24 mrt. 2020 om 14:51 schreef Yaakov Selkowitz: > > > However, I created a "fedora" branch in (upstream) Tcl, in which > > > I merged the two patches from fedora. Result: > > > > >=20 > > The errors I see there are "Test file error: can't find package > > tcltests", which sounds like an issue with the test environment and not > > on those changes. >=20 > The point is, Tcl has a specific order of paths where it searches its > environment, like an $auto_path variable. The test-suite tests > this algorithm, and - apparently - the outcome of the algorith > changed. You can add additional paths, but you cannot change > the order of existing paths that are searched. So, sorry, but > I respectfully disagree. The test-suite adds a path where it > can find the "tcltests" package, the fedora changes result > in not finding that package any more. That's a bug in the > path search algorithm, which is modified by the fedora patch. Fedora, and possibly other distros as well, set a default search path for tcl that conforms with their desired filesystem layout -- having all extensions under /usr/{lib,share}/tclX.Y instead of scattered throughout /usr/{lib,share}. Customing the directory layout of interpreted language extensions is a common and accepted downstream practice. Therefore, it would be a bug in the test environment, e.g. in not using the Tcl it is testing to determine where tcltests should be installed. -- Yaakov