From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-045.btinternet.com (mailomta1-sa.btinternet.com [213.120.69.7]) by sourceware.org (Postfix) with ESMTPS id 9271739CBC23 for ; Sun, 11 Apr 2021 15:17:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9271739CBC23 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=jon.turney@dronecode.org.uk Received: from sa-prd-rgout-002.btmx-prd.synchronoss.net ([10.2.38.5]) by sa-prd-fep-045.btinternet.com with ESMTP id <20210411151705.OJEQ12389.sa-prd-fep-045.btinternet.com@sa-prd-rgout-002.btmx-prd.synchronoss.net>; Sun, 11 Apr 2021 16:17:05 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com X-SNCR-Rigid: 60387183064D366D X-Originating-IP: [81.153.98.246] X-OWM-Source-IP: 81.153.98.246 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeduledrudekhedgudeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenogfuuhhsphgvtghtffhomhgrihhnucdlgeelmdenucfjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpedtuefhfedtgfevvddtudeffeevieevjeegffehheffhffhhfejvefftedujeeutdenucffohhmrghinhepghhoohhglhgvrdgtohhmnecukfhppeekuddrudehfedrleekrddvgeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurdduuddungdpihhnvghtpeekuddrudehfedrleekrddvgeeipdhmrghilhhfrhhomhepoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqecuuefqffgjpeekuefkvffokffogfdprhgtphhtthhopeeouehrihgrnhdrkfhnghhlihhssefuhihsthgvmhgrthhitgfufidrrggsrdgtrgeqpdhrtghpthhtohepoegthihgfihinhdqrghpphhssegthihgfihinhdrtghomheq X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.111] (81.153.98.246) by sa-prd-rgout-002.btmx-prd.synchronoss.net (5.8.340) (authenticated as jonturney@btinternet.com) id 60387183064D366D; Sun, 11 Apr 2021 16:17:05 +0100 Subject: Re: [ITA] fortune-mod - please review To: brian Inglis , "cygwin-apps@cygwin.com" References: From: Jon Turney Message-ID: <1e2133e8-d234-508f-5cc2-221ae8a3487c@dronecode.org.uk> Date: Sun, 11 Apr 2021 16:16:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3570.6 required=5.0 tests=BAYES_00, FORGED_SPF_HELO, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Apr 2021 15:17:08 -0000 On 09/04/2021 17:49, Brian Inglis wrote: > Please review: > > - build now uses cmake > - build requires unpackaged cpan module, installing with cpan in .cygport > - x86 will not build with ninja, only if deinstalled > - x86 applies but also regenerates source patches Can you be a bit more explicit what the issues are on x86? > See Google Drive for review files: > https://drive.google.com/drive/folders/15500wdTKygcwVNB7-0XN9P6kd9pvByxJ For future reference, giving a link to the cygport, rather than having to dig it out of the source package would ease review. > DEPEND="cmake ninja perl" > BUILD_REQUIRES="$DEPEND" build requires also seem to include Perl-Path-Tiny. > cpan App::XML::DocBook::Builder This is less than ideal, as this means this gets executed as a side effect any time the cygport is sourced (e.g. if you run 'cygport fortune-mod.cygport info'). If you really can't get this packaged, maybe it should be in the src_compile instead? Apart from that, looks good.