From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id BF56B386F457 for ; Fri, 15 May 2020 04:55:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BF56B386F457 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=yselkowitz@cygwin.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-POxnVSI7Mm6Fgc1j8gh_HQ-1; Fri, 15 May 2020 00:55:47 -0400 X-MC-Unique: POxnVSI7Mm6Fgc1j8gh_HQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 50A898005AD for ; Fri, 15 May 2020 04:55:46 +0000 (UTC) Received: from ovpn-112-6.rdu2.redhat.com (ovpn-112-6.rdu2.redhat.com [10.10.112.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F2BCD620AF for ; Fri, 15 May 2020 04:55:45 +0000 (UTC) Message-ID: <1e2bd9cc5346a540b1a355847af57476f6ccedab.camel@cygwin.com> Subject: Re: cygport development From: Yaakov Selkowitz To: cygwin-apps@cygwin.com Date: Fri, 15 May 2020 00:55:44 -0400 In-Reply-To: <7ac8dfe8-b7ae-8d4d-03aa-a8fbd95a00ef@gmail.com> References: <3501279f-70c8-042c-2e60-2cd315277ae9@SystematicSw.ab.ca> <97e449ba-2c23-a110-ce95-850394b398cf@gmail.com> <871rvgwqbc.fsf@Rainer.invalid> <0d57d59b-638f-47ae-bdd0-eefda2e63f0c@gmail.com> <7ac8dfe8-b7ae-8d4d-03aa-a8fbd95a00ef@gmail.com> User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: cygwin.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2020 04:55:51 -0000 On Tue, 2020-05-12 at 16:59 +0200, Federico Kircheis wrote: > On 10/14/19 10:55 AM, Federico Kircheis wrote: > > On 13/10/2019 18.41, Achim Gratz wrote: > > > Federico Kircheis writes: > > > > I've sent the patches the 14.07.19, unfortunately I still got no an= swer. > > >=20 > > > The cygport maintainer is rather busy with non-Cygwin related work th= ese > > > days, I suppose. Anyway, one of the questions I have is why you need > > > these changes. Most build systems do not actually work when they > > > encounter a path with spaces if they use make under the hood, so fixi= ng > > > cygport to grok such path locations isn't getting you much further I'= d > > > think. Can you explain? > >=20 > > Yep. > >=20 > > I've built some software in my windows home directory. > > It contains a space. > > I expected it to work. > >=20 > > Instead of failing with a clear error message, the build process delete= d=20 > > some unrelated files as it cd failed (or cd in the wrong directory, can= t=20 > > remember right now). > >=20 > > I believe it is unacceptable to delete unrelated data. > >=20 > > Even if it stated that there is no intention to support path with=20 > > spaces, those scripts should fail fast and ideally with a clear error= =20 > > message. > >=20 > > I found it easier to quote the offending variables, as not only spaces= =20 > > might cause issues. >=20 > The merge request in the repository has been closed. >=20 > I'm attaching the updated patch. This patch is clearly not limited to the protection of data, as it quotes variables that could in no way contain a space or have anything to do with file paths. As mentioned multiple times, using filenames ore directories with spaces is asking for trouble, and I have no interest in trying to support such a case. I'm willing to consider a *limited* patch that makes sure that cygport doesn't do something it shouldn't in that case, but that's about it. -- Yaakov=20