From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20221 invoked by alias); 27 Nov 2017 14:59:39 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 20207 invoked by uid 89); 27 Nov 2017 14:59:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=site, Hx-spam-relays-external:ESMTPA X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Nov 2017 14:59:37 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A81A920C6B for ; Mon, 27 Nov 2017 09:59:35 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Mon, 27 Nov 2017 09:59:35 -0500 X-ME-Sender: Received: from [192.168.1.102] (host86-158-32-25.range86-158.btcentralplus.com [86.158.32.25]) by mail.messagingengine.com (Postfix) with ESMTPA id 4ADD624136 for ; Mon, 27 Nov 2017 09:59:35 -0500 (EST) Subject: Re: [PATCH setup, v2] site.cc, site.h: code cleanup To: cygwin-apps@cygwin.com References: <20171124172927.4372-1-kbrown@cornell.edu> From: Jon Turney Message-ID: <1e81701f-f757-27bd-82ec-4b15abec307b@dronecode.org.uk> Date: Mon, 27 Nov 2017 14:59:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171124172927.4372-1-kbrown@cornell.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00112.txt.bz2 On 24/11/2017 17:29, Ken Brown wrote: > Remove site_list_type::init(), which was introduced to work around a > problem with gcc-2.95. > > Add a bool member 'from_mirrors_lst' to the site_list_type class. Use > it to distinguish mirrors listed in mirrors.lst from user-added sites. > This replaces the (undocumented) use of > site_list_type::servername.size() for this purpose. > > When registerSavedSite is called on a URL that's already in > 'all_site_list', add the version from 'all_site_list' to 'site_list' > rather than adding a temporary version that contains no information > other than the URL. > > Similarly, if the user adds a site that was already in > 'all_site_list', don't replace the existent version with the new one > (which contains only the URL). > --- > site.cc | 42 ++++++++++++++++++------------------------ > site.h | 9 +++++---- > 2 files changed, 23 insertions(+), 28 deletions(-) Please apply.