From: Ken Brown <kbrown@cornell.edu>
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: Use of Win32 API in harfbuzz
Date: Tue, 13 Nov 2018 14:18:00 -0000 [thread overview]
Message-ID: <1ea22af3-0e87-b845-af3a-15c17a2e3c85@cornell.edu> (raw)
In-Reply-To: <22165fae-2b9c-c872-e920-6d0983786c9e@cornell.edu>
On 7/12/2018 12:24 PM, Ken Brown wrote:
> Yaakov,
>
> A recent commit in upstream harfbuzz (ce17340) used the Win32 API on Cygwin. I
> was about to send a patch upstream to fix this, but I thought I should first
> check for such uses in the current Cygwin release (1.7.6-1). The attached patch
> removes the ones I found.
>
> Am I right in removing all of these, or should some be kept? I wasn't sure
> about the calls to setmode(), for example.
>
> And is it OK with you for me to send Cygwin patches upstream, or would you
> rather be the one communicating with them?
I never got a reply, so I went ahead and sent an updated version of the patch
upstream:
https://github.com/harfbuzz/harfbuzz/pull/1380
Yaakov, please comment there if you have a chance to take a look.
Ken
prev parent reply other threads:[~2018-11-13 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 16:25 Ken Brown
2018-11-13 14:18 ` Ken Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ea22af3-0e87-b845-af3a-15c17a2e3c85@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).