pregerenated cinstall/configure broken in cvs

pregerenated cinstall/configure broken in cvs

[Jan Nieuwenhuizen]

Hi,

I've sent a patch a while ago that included a 'fix' for
cinstall/configure.in wrt CFLAGS; but I could not reproduce the error,
so it was removed.

It turns out that the pregenerated configure in cinstall is buggy.
Can someone check in a freshly generated configure?

After a fresh checkout, I get:

    11:32:51 fred@appel:~cinstall$ MINGW32=yes CFLAGS='-mno-cygwin' ./configure
    creating cache ./config.cache
    checking host system type... powerpc-unknown-linux-gnu
    checking target system type... powerpc-unknown-linux-gnu
    checking build system type... powerpc-unknown-linux-gnu
    checking for gcc... gcc
    checking whether we are using GNU C... yes
    checking whether gcc accepts -g... yes
    checking for g++... g++
    ./configure: CFLAGS: command not found

Running autoconf makes this go away (no patch needed), that's why we
couldn't reproduce it.  Here's a snippet of the pre/post autoconf diff:

    diff -u ../cinstall.orig/configure .
    [..]
    @@ -886,7 +875,7 @@
       test -z "$CC" && { echo "configure: error: no acceptable cc found in \$PATH" 1>&2; exit 1; }
     fi

    -CXXFLAGS="$(CFLAGS)"
    +CXXFLAGS='$(CFLAGS)'


     if test "$program_transform_name" = s,x,x,; then

Greetings,
Jan.

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music typesetter
http://www.xs4all.nl/~jantien       | http://www.lilypond.org

Re: pregerenated cinstall/configure broken in cvs

[Christopher Faylor]

On Tue, Jan 29, 2002 at 11:46:23AM +0100, Jan Nieuwenhuizen wrote:
>Hi,
>
>I've sent a patch a while ago that included a 'fix' for
>cinstall/configure.in wrt CFLAGS; but I could not reproduce the error,
>so it was removed.
>
>It turns out that the pregenerated configure in cinstall is buggy.
>Can someone check in a freshly generated configure?
>
>After a fresh checkout, I get:
>
>    11:32:51 fred@appel:~cinstall$ MINGW32=yes CFLAGS='-mno-cygwin' ./configure
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Why are you doing this?  It's not necessary.

Regardless, I've regenerated the configure script.  I'm not sure why
it was in that state.

cgf

Re: pregerenated cinstall/configure broken in cvs

[Jan Nieuwenhuizen]

Christopher Faylor <cgf@redhat.com> writes:

>>    11:32:51 fred@appel:~cinstall$ MINGW32=yes CFLAGS='-mno-cygwin' ./configure
>                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Why are you doing this?  It's not necessary.

I don't know.  It was in ancient times, to avoid linking to
cygwin1.dll, and haven't ever checked since.  Thanks for the hint,
I'll look into it.

> Regardless, I've regenerated the configure script.  I'm not sure why
> it was in that state.

Thanks,
Jan.

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music typesetter
http://www.xs4all.nl/~jantien       | http://www.lilypond.org

Re: pregerenated cinstall/configure broken in cvs

[Christopher Faylor]

On Tue, Jan 29, 2002 at 05:11:32PM +0100, Jan Nieuwenhuizen wrote:
>Christopher Faylor <cgf@redhat.com> writes:
>>>    11:32:51 fred@appel:~cinstall$ MINGW32=yes CFLAGS='-mno-cygwin' ./configure
>>                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> Why are you doing this?  It's not necessary.
>
>I don't know.  It was in ancient times, to avoid linking to
>cygwin1.dll, and haven't ever checked since.

I sincerely doubt this.  I've been working with setup.exe for a while now
and I've never had to do this.  IF I had to do this, I would have fixed
the problem not kludged around it (hint).

cgf

>Thanks for the hint, I'll look into it.

Re: pregerenated cinstall/configure broken in cvs

[Jan Nieuwenhuizen]

Christopher Faylor <cgf@redhat.com> writes:

> I sincerely doubt this.  I've been working with setup.exe for a while now
> and I've never had to do this.

You're right.  It's not needed.

> IF I had to do this, I would have fixed the problem not kludged
> around it (hint).

Just fixed some other small bug, will I still lose points?
:-)

Jan.

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music typesetter
http://www.xs4all.nl/~jantien       | http://www.lilypond.org

Re: pregerenated cinstall/configure broken in cvs

[Christopher Faylor]

On Tue, Jan 29, 2002 at 10:25:38PM +0100, Jan Nieuwenhuizen wrote:
>Christopher Faylor <cgf@redhat.com> writes:
>
>> I sincerely doubt this.  I've been working with setup.exe for a while now
>> and I've never had to do this.
>
>You're right.  It's not needed.
>
>> IF I had to do this, I would have fixed the problem not kludged
>> around it (hint).
>
>Just fixed some other small bug, will I still lose points?
>:-)

Nope.  You're back in positive points territory...  Actually you never
dropped.  That was just an idle implication.

Thanks for the bug fix!

cgf