From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-apps@cygwin.com
Subject: Re: which for cygwin 1.7
Date: Sat, 13 Dec 2008 09:38:00 -0000 [thread overview]
Message-ID: <20081213094021.GO32197@calimero.vinschen.de> (raw)
In-Reply-To: <4942E9D4.1070808@acm.org>
On Dec 12 14:46, David Rothenberger wrote:
> I've been looking at rebuilding which for cygwin 1.7. I think there are a
> lot of problems with the current code. It uses static buffers of PATH_MAX
> all over the place, some of which are passed to getcwd().
For a start that would be fine. By rebuilding you get static buffers
of the new PATH_MAX size. As long as which checks if the path length
doesn't exceed the buffer size, it should be safe to use. It wouldn't
work for paths > 4K, but that's a far way off. Just check if it uses
strlen() > PATH_MAX or strncpy(a,b,PATH_MAX) sort of expressions.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat
prev parent reply other threads:[~2008-12-13 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 23:00 David Rothenberger
2008-12-13 9:38 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081213094021.GO32197@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).