public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-apps@cygwin.com
Subject: Re: GCC4 status.
Date: Wed, 25 Feb 2009 17:37:00 -0000	[thread overview]
Message-ID: <20090225173648.GO18319@calimero.vinschen.de> (raw)
In-Reply-To: <49A5804D.20602@gmail.com>

On Feb 25 17:30, Dave Korn wrote:
> Corinna Vinschen wrote:
> 
> > #1)
> > 
> >   sftp.c:368: warning: 'opterr' redeclared without dllimport attribute:
> >   previous dllimport ignored
> > 
> >   Yes, well, so what?
> 
>   This one IIRC has some significance.  If you declare any extern symbols at
> all with dllimport attributes, it disables auto-import altogether.  So a stray
> definition like that can break linking all the other functions that would
> normally be auto-imported.

So why does it do that at all: "previous dllimport ignored"?
It shouldn't do that.  The dllimport should have precedence, IMHO.

> > #2)
> > 
> >   /usr/lib/gcc/i686-pc-cygwin/4.3.2/../../../../i686-pc-cygwin/bin/ld:
> >   warning: auto-importing has been activated without --enable-auto-import
> >   specified on the command line.
> >   This should work unless it involves constant data structures referencing
> >   symbols from auto-imported DLLs.
> > 
> >   *Sob*  Yes, officer, I confess everything!  But *please* don't tell
> >   me this every time I dare to link an application.
> > 
> > Is there any chance to get rid of this really useless stuff upstream?
> 
>   I don't know.  We could turn on auto import globally but that will pessimize
> a whole bunch of stuff that needn't be affected.  We could discard the warning
> altogether but then people would get silent failures.

I think auto import should be the default.  You don't have this problem
and the message on any other platform.  Why isn't the default setting so
that we get what other platforms get, too?  I never had the case so far
where auto import would have hurt.  Am I just maintaining too simple
projects?

>   As a workaround, the sources could always be fixed.  Inconsistent
> declarations *is* a correctness issue, after all, and it's usually trivial to
> add an item to LDFLAGS.

There's only so much platform uglification put up with in the upstream
OpenSSH sources...

>   Also, perhaps as a half-way compromise measure, auto import could be enabled
> in the GCC specs for just C++/ObjC++/Java.  I don't know what's for the best
> yet, does anyone else have any suggestions?

...which are written in plain C, btw.  So this compromise is none
for a lot of packages in the Cygwin distro, not only for OpenSSH.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

  reply	other threads:[~2009-02-25 17:37 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-24  2:44 Dave Korn
2009-02-24  3:04 ` Dave Korn
2009-02-24  3:59 ` Yaakov (Cygwin/X)
2009-02-24  4:05   ` Dave Korn
2009-02-24  5:05     ` Charles Wilson
2009-02-24  5:18       ` Christopher Faylor
2009-02-24  5:27         ` Charles Wilson
2009-02-24  5:51           ` Christopher Faylor
2009-02-24  6:40             ` Yaakov (Cygwin/X)
2009-02-24  9:15           ` Corinna Vinschen
2009-02-24 16:35             ` Christopher Faylor
2009-02-24 16:53               ` Corinna Vinschen
2009-02-24 18:13                 ` Dave Korn
2009-02-25 14:21                   ` Corinna Vinschen
2009-02-25 17:21                     ` Dave Korn
2009-02-25 17:37                       ` Corinna Vinschen [this message]
2009-02-26  4:36                         ` Dave Korn
2009-02-26  5:05                           ` Danny Smith
2009-02-26  3:37                       ` Charles Wilson
2009-02-26  5:16                         ` Danny Smith
2009-02-26  5:36                           ` Charles Wilson
2009-02-26  5:58                             ` Dave Korn
2009-02-26  3:29                     ` Charles Wilson
2009-02-26  3:47                       ` Yaakov (Cygwin/X)
2009-02-26  3:54                         ` Charles Wilson
2009-02-26  4:23                           ` Dave Korn
2009-02-24 12:37       ` Dave Korn
2009-02-24 14:29         ` Charles Wilson
2009-02-24 14:41           ` Dave Korn
2009-02-24 16:12           ` Christopher Faylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090225173648.GO18319@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).