From: Christopher Faylor <cgf-use-the-mailinglist-please@cygwin.com>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH 1/4 setup] package re-/de-installation from CLI
Date: Mon, 07 Oct 2013 16:21:00 -0000 [thread overview]
Message-ID: <20131007162108.GA3534@ednor.casa.cgf.cx> (raw)
In-Reply-To: <5252CD17.4080001@dronecode.org.uk>
On Mon, Oct 07, 2013 at 04:02:47PM +0100, Jon TURNEY wrote:
>On 24/07/2013 21:53, Achim Gratz wrote:
>> From 1686e0beac98867bf1fe358a8fe9a9d8647d4a3a Mon Sep 17 00:00:00 2001
>> From: Achim Gratz <Stromeko-GL6zORMxvAD+tKtrA809HA@public.gmane.org>
>> Date: Fri, 8 Feb 2013 20:58:20 +0100
>> Subject: [PATCH 1/4] Remove detrimental initialization
>>
>> * choose.cc (createListview): Remove superflous and detrimental
>> default trust setting. This has already been set correctly
>> in OnInit.
>> ---
>> choose.cc | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/choose.cc b/choose.cc
>> index 6d5f3b7..4e0bcd4 100644
>> --- a/choose.cc
>> +++ b/choose.cc
>> @@ -148,11 +148,6 @@ ChooserPage::createListview ()
>> log (LOG_BABBLE) << "Failed to set View button caption %ld" <<
>> GetLastError () << endLog;
>>
>> - for (packagedb::packagecollection::iterator i = db.packages.begin(); i != db.packages.end(); i++)
>> - {
>> - i->second->set_requirements(chooser->deftrust);
>> - }
>> -
>
>There have been a few reports that setup no longer installs the dependencies
>of explicitly specified packages in unattended mode, and this seems to be the
>culprit.
>
>A small patch to fix this is attached.
Thanks for finding this. Please check it in and I'll roll out a new version
of setup.exe.
>(I note with amazement that setup has two dependency solvers: one in
>PrereqChecker, and one in packageversion)
Sigh. I didn't know that. Have I mentioned...? Yes. Nevermind. I'm
pretty sure I have.
cgf
next prev parent reply other threads:[~2013-10-07 16:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 18:03 [setup] " Achim Gratz
2013-07-24 11:51 ` Corinna Vinschen
2013-07-24 20:45 ` [PATCH 0/4 setup] " Achim Gratz
2013-07-24 20:53 ` [PATCH 2/4 " Achim Gratz
2013-07-25 12:04 ` Corinna Vinschen
2013-07-24 20:53 ` [PATCH 1/4 " Achim Gratz
2013-07-25 9:48 ` Corinna Vinschen
2013-10-07 15:03 ` Jon TURNEY
2013-10-07 16:21 ` Christopher Faylor [this message]
2013-10-07 18:08 ` Jon TURNEY
2013-10-10 20:05 ` Achim Gratz
2013-10-07 18:00 ` Achim Gratz
2013-07-24 20:54 ` [PATCH 4/4 " Achim Gratz
2013-07-26 12:04 ` Corinna Vinschen
2013-07-24 20:54 ` [PATCH 3/4 " Achim Gratz
2013-07-25 12:06 ` Corinna Vinschen
2013-07-25 19:52 ` Achim Gratz
2013-07-24 20:58 ` [PATCH 0/4 " Achim Gratz
2013-07-25 0:03 ` Christopher Faylor
2013-07-25 5:29 ` Achim Gratz
2013-07-25 15:18 ` Christopher Faylor
2013-07-25 19:44 ` Achim Gratz
2013-07-24 20:51 ` [PATCH 1/4 " Achim Gratz
2013-07-24 20:51 ` [PATCH 4/4 " Achim Gratz
2013-07-24 20:51 ` [PATCH 3/4 " Achim Gratz
2013-07-24 20:51 ` [PATCH 2/4 " Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131007162108.GA3534@ednor.casa.cgf.cx \
--to=cgf-use-the-mailinglist-please@cygwin.com \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).