From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15995 invoked by alias); 7 Oct 2013 16:21:13 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 15983 invoked by uid 89); 7 Oct 2013 16:21:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: mho-01-ewr.mailhop.org Received: from mho-03-ewr.mailhop.org (HELO mho-01-ewr.mailhop.org) (204.13.248.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 07 Oct 2013 16:21:11 +0000 Received: from pool-98-110-183-21.bstnma.fios.verizon.net ([98.110.183.21] helo=cgf.cx) by mho-01-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1VTDYT-000MWC-MA for cygwin-apps@cygwin.com; Mon, 07 Oct 2013 16:21:09 +0000 Received: from cgf.cx (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id C93EA60125 for ; Mon, 7 Oct 2013 12:21:08 -0400 (EDT) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19PoJnEypixiRWUCX4aeblx Date: Mon, 07 Oct 2013 16:21:00 -0000 From: Christopher Faylor To: cygwin-apps@cygwin.com Subject: Re: [PATCH 1/4 setup] package re-/de-installation from CLI Message-ID: <20131007162108.GA3534@ednor.casa.cgf.cx> Reply-To: cygwin-apps@cygwin.com Mail-Followup-To: cygwin-apps@cygwin.com References: <87a9lexyk8.fsf@Rainer.invalid> <20130724115129.GT9689@calimero.vinschen.de> <874nbjbsbw.fsf@Rainer.invalid> <874nbjade0.fsf_-_@Rainer.invalid> <5252CD17.4080001@dronecode.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5252CD17.4080001@dronecode.org.uk> User-Agent: Mutt/1.5.20 (2009-06-14) X-SW-Source: 2013-10/txt/msg00048.txt.bz2 On Mon, Oct 07, 2013 at 04:02:47PM +0100, Jon TURNEY wrote: >On 24/07/2013 21:53, Achim Gratz wrote: >> From 1686e0beac98867bf1fe358a8fe9a9d8647d4a3a Mon Sep 17 00:00:00 2001 >> From: Achim Gratz >> Date: Fri, 8 Feb 2013 20:58:20 +0100 >> Subject: [PATCH 1/4] Remove detrimental initialization >> >> * choose.cc (createListview): Remove superflous and detrimental >> default trust setting. This has already been set correctly >> in OnInit. >> --- >> choose.cc | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/choose.cc b/choose.cc >> index 6d5f3b7..4e0bcd4 100644 >> --- a/choose.cc >> +++ b/choose.cc >> @@ -148,11 +148,6 @@ ChooserPage::createListview () >> log (LOG_BABBLE) << "Failed to set View button caption %ld" << >> GetLastError () << endLog; >> >> - for (packagedb::packagecollection::iterator i = db.packages.begin(); i != db.packages.end(); i++) >> - { >> - i->second->set_requirements(chooser->deftrust); >> - } >> - > >There have been a few reports that setup no longer installs the dependencies >of explicitly specified packages in unattended mode, and this seems to be the >culprit. > >A small patch to fix this is attached. Thanks for finding this. Please check it in and I'll roll out a new version of setup.exe. >(I note with amazement that setup has two dependency solvers: one in >PrereqChecker, and one in packageversion) Sigh. I didn't know that. Have I mentioned...? Yes. Nevermind. I'm pretty sure I have. cgf