* [PATCH] genini: support new tags
@ 2013-10-07 19:28 Yaakov (Cygwin/X)
2013-10-07 19:46 ` Christopher Faylor
0 siblings, 1 reply; 5+ messages in thread
From: Yaakov (Cygwin/X) @ 2013-10-07 19:28 UTC (permalink / raw)
To: cygwin-apps
[-- Attachment #1: Type: text/plain, Size: 101 bytes --]
The attached patch for genini allows it to recognize (and ignore) the
new setup.hint tags.
Yaakov
[-- Attachment #2: genini-new-tags.patch --]
[-- Type: text/x-patch, Size: 622 bytes --]
2013-10-07 Yaakov Selkowitz <yselkowitz@...>
* genini (parse): Ignore arch:, release:, and skip: tags.
Index: genini
===================================================================
RCS file: /cvs/cygwin-apps/genini/genini,v
retrieving revision 1.14
diff -u -p -r1.14 genini
--- genini 17 Jul 2013 16:33:16 -0000 1.14
+++ genini 7 Oct 2013 19:24:32 -0000
@@ -139,6 +139,15 @@ sub parse {
$main::setup_version = $_;
next;
};
+ /^arch:/ and do {
+ next;
+ };
+ /^release:/ and do {
+ next;
+ };
+ /^skip:/ and do {
+ next;
+ };
/^\@\s+(\S+)/ and do {
$pname = $1;
$what = '';
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] genini: support new tags
2013-10-07 19:28 [PATCH] genini: support new tags Yaakov (Cygwin/X)
@ 2013-10-07 19:46 ` Christopher Faylor
2013-10-07 19:59 ` Yaakov (Cygwin/X)
0 siblings, 1 reply; 5+ messages in thread
From: Christopher Faylor @ 2013-10-07 19:46 UTC (permalink / raw)
To: cygwin-apps
On Mon, Oct 07, 2013 at 02:28:00PM -0500, Yaakov (Cygwin/X) wrote:
>The attached patch for genini allows it to recognize (and ignore) the
>new setup.hint tags.
Only skip: is a valid setup.hint tag.
cgf
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] genini: support new tags
2013-10-07 19:46 ` Christopher Faylor
@ 2013-10-07 19:59 ` Yaakov (Cygwin/X)
2013-10-07 20:04 ` Christopher Faylor
0 siblings, 1 reply; 5+ messages in thread
From: Yaakov (Cygwin/X) @ 2013-10-07 19:59 UTC (permalink / raw)
To: cygwin-apps
On 2013-10-07 14:46, Christopher Faylor wrote:
> On Mon, Oct 07, 2013 at 02:28:00PM -0500, Yaakov (Cygwin/X) wrote:
>> The attached patch for genini allows it to recognize (and ignore) the
>> new setup.hint tags.
>
> Only skip: is a valid setup.hint tag.
OK, bad wording, but genini accepts an existing setup.ini as input, so
it needs to understands its tags as well.
Yaakov
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] genini: support new tags
2013-10-07 19:59 ` Yaakov (Cygwin/X)
@ 2013-10-07 20:04 ` Christopher Faylor
2013-10-11 20:31 ` Christopher Faylor
0 siblings, 1 reply; 5+ messages in thread
From: Christopher Faylor @ 2013-10-07 20:04 UTC (permalink / raw)
To: cygwin-apps
On Mon, Oct 07, 2013 at 02:59:28PM -0500, Yaakov (Cygwin/X) wrote:
>On 2013-10-07 14:46, Christopher Faylor wrote:
>> On Mon, Oct 07, 2013 at 02:28:00PM -0500, Yaakov (Cygwin/X) wrote:
>>> The attached patch for genini allows it to recognize (and ignore) the
>>> new setup.hint tags.
>>
>> Only skip: is a valid setup.hint tag.
>
>OK, bad wording, but genini accepts an existing setup.ini as input, so
>it needs to understands its tags as well.
Ok. I guess genini is more forgiving about accepting setup.ini keywords.
FWIW, I will probably be removing parsing of setup.ini from upset at some
point. upset no longer reads setup.ini when generating a new setup.ini.
Go ahead and check in. Thanks for the patch.
cgf
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] genini: support new tags
2013-10-07 20:04 ` Christopher Faylor
@ 2013-10-11 20:31 ` Christopher Faylor
0 siblings, 0 replies; 5+ messages in thread
From: Christopher Faylor @ 2013-10-11 20:31 UTC (permalink / raw)
To: cygwin-apps
On Mon, Oct 07, 2013 at 04:04:10PM -0400, Christopher Faylor wrote:
>On Mon, Oct 07, 2013 at 02:59:28PM -0500, Yaakov (Cygwin/X) wrote:
>>On 2013-10-07 14:46, Christopher Faylor wrote:
>>> On Mon, Oct 07, 2013 at 02:28:00PM -0500, Yaakov (Cygwin/X) wrote:
>>>> The attached patch for genini allows it to recognize (and ignore) the
>>>> new setup.hint tags.
>>>
>>> Only skip: is a valid setup.hint tag.
>>
>>OK, bad wording, but genini accepts an existing setup.ini as input, so
>>it needs to understands its tags as well.
>
>Ok. I guess genini is more forgiving about accepting setup.ini keywords.
>
>FWIW, I will probably be removing parsing of setup.ini from upset at some
>point. upset no longer reads setup.ini when generating a new setup.ini.
Actually, this is nonsense. I forgot that I still have to parse setup.ini
for some stuff.
cgf
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-11 20:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-07 19:28 [PATCH] genini: support new tags Yaakov (Cygwin/X)
2013-10-07 19:46 ` Christopher Faylor
2013-10-07 19:59 ` Yaakov (Cygwin/X)
2013-10-07 20:04 ` Christopher Faylor
2013-10-11 20:31 ` Christopher Faylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).